Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeseries EC_adj #1724

Merged
merged 5 commits into from
May 20, 2024
Merged

Fix timeseries EC_adj #1724

merged 5 commits into from
May 20, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented May 19, 2024

Pull Request Description

Aligns timeseries EC_adj output with hot water energy use output. They were previously off by a timestep because of the EMS lag.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this May 19, 2024
@shorowit shorowit merged commit 4488d4d into master May 20, 2024
7 checks passed
@shorowit shorowit deleted the timeseries_ec_adj branch May 20, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant