MJ8 infiltration/ventilation #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
commented
May 15, 2024
yzhou601
reviewed
May 17, 2024
| vent_mech_cfis = hpxml_bldg.ventilation_fans.find { |vent_mech| vent_mech.fan_type == HPXML::MechVentTypeCFIS && vent_mech.distribution_system_idref == hvac_distribution.id } | ||
| return if vent_mech_cfis.nil? | ||
|
|
||
| vent_cfm = vent_mech_cfis.total_unit_flow_rate |
There was a problem hiding this comment.
Also, should we exclude the cfis cfms from the ventilation load calculation (q_bal_cfm)? I feel we do want it for infiltration adjustments considering it's analyzing all the air flows in the house.
There was a problem hiding this comment.
Worksheet E says:
I assume they say "may" instead of "will" because you could have an additional exhaust fan that runs when CFIS runs in order to create balanced ventilation. But if you don't have that, then I assume it should be included like we are.
…o mj8_ventilation # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/base_results/results_sizing.csv
…o mj8_ventilation # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/base_results/results_sizing.csv
…HPXML into mj8_ventilation
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1711. Updates vent/infil calcs to be consistent with MJ8.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)Documentation has been updatedChangelog has been updatedopenstudio tasks.rb update_measureshas been run