Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Sensible Capacity Curves with ADP/BF #1707

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Replace Sensible Capacity Curves with ADP/BF #1707

wants to merge 18 commits into from

Commits on Apr 2, 2024

  1. Committing pseudo_code_heat_pump_sizing.txt to branch OS_ACCA_Man_S_u… 

    …pdate
    @Sashadf1
    Sashadf1 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    698aaf4 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. adding comment on apply_equipment_adjustments

    @Sashadf1
    Sashadf1 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1ac11a2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into acca_manual_s

    @Sashadf1
    Sashadf1 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    82e23b6 View commit details
    Browse the repository at this point in the history

  3. adding explanatory comments

    @Sashadf1
    Sashadf1 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    af484e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. hvac_sizing.rb

    @Sashadf1
    Sashadf1 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    49e998d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Committing comments for ADP/BF

    @Sashadf1
    Sashadf1 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2aca92f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into adp_bf_method_design_shr

    @Sashadf1
    Sashadf1 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6861e46 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Translating E+ coil bypass factor method to recalculate cool_cap_design

    @Sashadf1
    Sashadf1 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    af58345 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. calculating A_o_rated with correct unit conversions and methods in ps… 

    …ychometrics.rb
    @Sashadf1
    Sashadf1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c1a7827 View commit details
    Browse the repository at this point in the history

  2. renamed A_o from A_o rated because A_o is not a function of design vs… 

    …. rated conditions
    @Sashadf1
    Sashadf1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2cdde89 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. refactor add_cooling_system function variable input order convention … 

    …to match add_heating_system function variable input order convention
    @Sashadf1
    Sashadf1 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1e3ef9a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. fixed typo in comments of CoilAoFactor method in psychrometrics.rb

    @Sashadf1
    Sashadf1 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7905315 View commit details
    Browse the repository at this point in the history

  2. fixed typo in descriptive comments of psychrometrics.rb

    @Sashadf1
    Sashadf1 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f9ed1b8 View commit details
    Browse the repository at this point in the history

  3. removing pesky return 1.0 that shouldn't be there, preventing it from… 

    … screwing things up when running OS CLI
    @Sashadf1
    Sashadf1 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    74bb5fa View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int… 

    …o adp_bf_method_design_shr
    @yzhou601
    yzhou601 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0391906 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. work on implementing ADP/BF. coil a_o factor already calculated in hv… 

    …ac.rb?
    @Sashadf1
    Sashadf1 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    85b2e27 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. using pre-existing coil ao factor stored in cooling additional proper… 

    …ties to calculate design SHR. Cool Cap Design throwing undefined variable error in Psychrometrics.CalculateSHR
    @Sashadf1
    Sashadf1 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d37f8c1 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. fixed unit conversion on cool_cap_rated so that Psychrometrics.rb doe… 

    …sn't numerically fail. hvac_cooling_ap.rated_shr and hvac_cooling_shr showing 0.05 discrepancy. ask team if this is a problem?
    @Sashadf1
    Sashadf1 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    26a55b3 View commit details
    Browse the repository at this point in the history