Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds geothermal loop outputs to annual results file #1689

Merged
merged 8 commits into from May 16, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Apr 18, 2024

Pull Request Description

Closes #1657.

Note: Branches off from room-by-room-sizing to avoid conflicts.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Apr 18, 2024
@shorowit shorowit self-assigned this Apr 18, 2024
@shorowit
Copy link
Contributor Author

Check if HVAC summary argument in the BuildResHPXML measure impacts Geothermal Loop outputs

@shorowit
Copy link
Contributor Author

Check if HVAC summary argument in the BuildResHPXML measure impacts Geothermal Loop outputs

Confirmed it does.

…dio-HPXML into geothermal_loop_outputs

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	ReportSimulationOutput/measure.xml
#	workflow/tests/base_results/results_simulations1_bills.csv
#	workflow/tests/base_results/results_simulations1_energy.csv
#	workflow/tests/base_results/results_simulations1_loads.csv
#	workflow/tests/base_results/results_simulations1_misc.csv
#	workflow/tests/base_results/results_simulations2_bills.csv
@shorowit shorowit marked this pull request as ready for review May 15, 2024 23:10
Base automatically changed from room-by-room-sizing to master May 16, 2024 00:46
@shorowit shorowit merged commit 99c70a2 into master May 16, 2024
@shorowit shorowit deleted the geothermal_loop_outputs branch May 16, 2024 00:46
@joseph-robertson joseph-robertson mentioned this pull request May 16, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add high-level geothermal loop details to annual_results.csv
1 participant