Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates default temperature capacitance multiplier to 7 #1668

Merged
merged 19 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ __New Features__
- Adds optional `Slab/extension/GapInsulationRValue` input for cases where a slab has horizontal (under slab) insulation.
- Allows radiant barriers for additional locations (attic gable walls and floor); reduced emissivity due to dust assumed for radiant barriers on attic floor.
- Adds window and skylight `GlassType` options of "low-e, high-solar-gain" and "low-e, low-solar-gain"; updates U-factor/SHGC lookup tables.
- Updates default temperature capacitance multiplier from 1 to 7, an average value found in the literature when calibrating timeseries EnergyPlus simulation results to field data.
- BuildResidentialHPXML measure:
- **Breaking change**: Replaces `roof_radiant_barrier`/`roof_radiant_barrier_grade` arguments with `radiant_barrier_attic_location`/`radiant_barrier_grade`.
- Allows specifying number of bedrooms served by the water heater which is used for apportioning tank losses; **Breaking change**: Replaces `water_heater_num_units_served` with `water_heater_num_bedrooms_served`.
Expand Down
8 changes: 4 additions & 4 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>46f04d09-a5c8-485b-a33e-096b981224db</version_id>
<version_modified>2024-05-16T00:57:35Z</version_modified>
<version_id>2f12c64a-de85-4d3b-947a-7ad02c951d28</version_id>
<version_modified>2024-05-16T01:53:08Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -351,7 +351,7 @@
<filename>hpxml_defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>EEB1E5B7</checksum>
<checksum>9F92F659</checksum>
</file>
<file>
<filename>hpxml_schema/HPXML.xsd</filename>
Expand Down Expand Up @@ -639,7 +639,7 @@
<filename>test_defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>8EEC2D8E</checksum>
<checksum>F86C090A</checksum>
</file>
<file>
<filename>test_enclosure.rb</filename>
Expand Down
2 changes: 1 addition & 1 deletion HPXMLtoOpenStudio/resources/hpxml_defaults.rb
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def self.apply_header(hpxml_header, epw_file)
end

if hpxml_header.temperature_capacitance_multiplier.nil?
hpxml_header.temperature_capacitance_multiplier = 1.0
hpxml_header.temperature_capacitance_multiplier = 7.0
hpxml_header.temperature_capacitance_multiplier_isdefaulted = true
end

Expand Down
4 changes: 2 additions & 2 deletions HPXMLtoOpenStudio/tests/test_defaults.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_header
hpxml.header.sim_calendar_year = 2020
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
default_hpxml, _default_hpxml_bldg = _test_measure()
_test_default_header_values(default_hpxml, 60, 1, 1, 12, 31, 2012, 1.0, nil, nil, nil)
_test_default_header_values(default_hpxml, 60, 1, 1, 12, 31, 2012, 7.0, nil, nil, nil)

# Test defaults - southern hemisphere
hpxml, _hpxml_bldg = _create_hpxml('base-location-capetown-zaf.xml')
Expand All @@ -68,7 +68,7 @@ def test_header
hpxml.header.temperature_capacitance_multiplier = nil
XMLHelper.write_file(hpxml.to_doc, @tmp_hpxml_path)
default_hpxml, _default_hpxml_bldg = _test_measure()
_test_default_header_values(default_hpxml, 60, 1, 1, 12, 31, 2007, 1.0, nil, nil, nil)
_test_default_header_values(default_hpxml, 60, 1, 1, 12, 31, 2007, 7.0, nil, nil, nil)
end

def test_emissions_factors
Expand Down
3 changes: 2 additions & 1 deletion docs/source/workflow_inputs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@ EnergyPlus simulation controls are entered in ``/HPXML/SoftwareInfo/extension/Si
``EndMonth`` integer >= 1, <= 12 No 12 (December) Run period end date
``EndDayOfMonth`` integer >= 1, <= 31 No 31 Run period end date
``CalendarYear`` integer > 1600 [#]_ No 2007 (for TMY weather) [#]_ Calendar year (for start day of week)
``TemperatureCapacitanceMultiplier`` double > 0 No 1.0 Multiplier on air heat capacitance [#]_
``TemperatureCapacitanceMultiplier`` double > 0 No 7.0 [#]_ Multiplier on air heat capacitance [#]_
==================================== ======== ======= ================ ======== =========================== =====================================

.. [#] BeginMonth/BeginDayOfMonth date must occur before EndMonth/EndDayOfMonth date (e.g., a run period from 10/1 to 3/31 is invalid).
.. [#] If a leap year is specified (e.g., 2008), the EPW weather file must contain 8784 hours.
.. [#] CalendarYear only applies to TMY (Typical Meteorological Year) weather. For AMY (Actual Meteorological Year) weather, the AMY year will be used regardless of what is specified.
.. [#] The default value of 7 is an average value found in the literature when calibrating timeseries EnergyPlus simulation results to field data.
.. [#] TemperatureCapacitanceMultiplier affects the transient calculation of indoor air temperatures.
Values greater than 1.0 have the effect of smoothing or damping the rate of change in the indoor air temperature from timestep to timestep.
This heat capacitance effect is modeled on top of any other individual mass inputs (e.g., furniture mass, partition wall mass, interior drywall, etc.) in the HPXML.
Expand Down
52 changes: 26 additions & 26 deletions workflow/tests/base_results/results_ashrae_140.csv
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
Test Case,Annual Heating Load [MMBtu],Annual Cooling Load [MMBtu]
L100AC.xml,51.41,N/A
L110AC.xml,77.05,N/A
L120AC.xml,39.84,N/A
L130AC.xml,43.86,N/A
L140AC.xml,48.05,N/A
L150AC.xml,40.85,N/A
L155AC.xml,44.14,N/A
L160AC.xml,52.19,N/A
L170AC.xml,62.0,N/A
L200AC.xml,124.27,N/A
L202AC.xml,131.27,N/A
L302XC.xml,46.87,N/A
L304XC.xml,45.2,N/A
L322XC.xml,66.93,N/A
L324XC.xml,48.62,N/A
L100AL.xml,N/A,51.47
L110AL.xml,N/A,55.25
L120AL.xml,N/A,47.69
L130AL.xml,N/A,36.35
L140AL.xml,N/A,24.32
L150AL.xml,N/A,64.56
L155AL.xml,N/A,48.79
L160AL.xml,N/A,62.49
L170AL.xml,N/A,42.11
L200AL.xml,N/A,64.53
L202AL.xml,N/A,54.83
L100AC.xml,51.28,N/A
L110AC.xml,76.84,N/A
L120AC.xml,39.74,N/A
L130AC.xml,43.88,N/A
L140AC.xml,48.15,N/A
L150AC.xml,40.49,N/A
L155AC.xml,43.88,N/A
L160AC.xml,52.13,N/A
L170AC.xml,61.89,N/A
L200AC.xml,123.75,N/A
L202AC.xml,130.8,N/A
L302XC.xml,46.8,N/A
L304XC.xml,45.13,N/A
L322XC.xml,66.99,N/A
L324XC.xml,48.68,N/A
L100AL.xml,N/A,50.42
L110AL.xml,N/A,54.33
L120AL.xml,N/A,46.96
L130AL.xml,N/A,35.82
L140AL.xml,N/A,24.02
L150AL.xml,N/A,62.19
L155AL.xml,N/A,46.92
L160AL.xml,N/A,61.5
L170AL.xml,N/A,41.14
L200AL.xml,N/A,63.27
L202AL.xml,N/A,54.21
16 changes: 8 additions & 8 deletions workflow/tests/base_results/results_hers_dse.csv
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Test Case,Heat/Cool (kWh or therm),HVAC Fan (kWh)
HVAC3a.xml,560.83,453.09
HVAC3e.xml,6335.32,980.03
HVAC3b.xml,677.0,660.0
HVAC3c.xml,588.34,525.48
HVAC3d.xml,640.83,624.83
HVAC3f.xml,7992.34,1236.76
HVAC3g.xml,6754.41,1042.16
HVAC3h.xml,7519.91,1137.99
HVAC3a.xml,557.36,450.16
HVAC3e.xml,6217.5,957.76
HVAC3b.xml,673.73,656.77
HVAC3c.xml,585.15,522.55
HVAC3d.xml,637.48,621.6
HVAC3f.xml,7859.29,1211.56
HVAC3g.xml,6632.49,1019.3
HVAC3h.xml,7388.32,1113.67
6 changes: 3 additions & 3 deletions workflow/tests/base_results/results_hers_hot_water.csv
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ L100AD-HW-05.xml,548.5,439.6
L100AD-HW-06.xml,227.5,5.9
L100AD-HW-07.xml,206.5,0.0
L100AM-HW-01.xml,110.3,0.0
L100AM-HW-02.xml,135.7,0.0
L100AM-HW-03.xml,90.9,0.0
L100AM-HW-02.xml,135.6,0.0
L100AM-HW-03.xml,90.8,0.0
L100AM-HW-04.xml,132.5,0.0
L100AM-HW-05.xml,295.8,439.6
L100AM-HW-05.xml,295.7,439.6
L100AM-HW-06.xml,122.7,5.9
L100AM-HW-07.xml,120.4,0.0
14 changes: 7 additions & 7 deletions workflow/tests/base_results/results_hers_hvac.csv
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Test Case,HVAC (kWh or therm),HVAC Fan (kWh)
HVAC1a.xml,6277.0,803.89
HVAC1b.xml,4660.12,803.89
HVAC2a.xml,639.47,623.36
HVAC2b.xml,554.21,623.36
HVAC2c.xml,7623.36,1192.21
HVAC2d.xml,4619.68,1192.21
HVAC2e.xml,14618.09,623.36
HVAC1a.xml,6160.65,786.9
HVAC1b.xml,4574.84,786.9
HVAC2a.xml,635.91,620.14
HVAC2b.xml,551.12,620.14
HVAC2c.xml,7589.08,1187.82
HVAC2d.xml,4600.92,1187.82
HVAC2e.xml,14536.62,620.14