Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIA SEDS Price Data #1656

Merged
merged 55 commits into from
May 27, 2024
Merged

EIA SEDS Price Data #1656

merged 55 commits into from
May 27, 2024

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Mar 21, 2024

Pull Request Description

Replace individual fuel prices with EIA State Energy Data System (SEDS) prices

About SEDS: https://www.eia.gov/state/seds/

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@bpark1327 bpark1327 self-assigned this Mar 21, 2024
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the PR checklist. Also, one initial comment below.

ReportUtilityBills/resources/simple_rates/README.md Outdated Show resolved Hide resolved
@bpark1327
Copy link
Collaborator Author

bpark1327 commented Apr 1, 2024

@nmerket @shorowit I observed a discrepancy in fuel prices between SEDS and each individual fuel page, except for electricity. I reached out to the EIA, and I received a response stating that they were surprised by the discrepancy. The individual mentioned that he would consult his colleagues who work on SEDS and update me if the SEDS team can provide any clarification. I'll keep you informed once I have more information.

@bpark1327 bpark1327 changed the title EIA Wood Price Data EIA SEDS Price Data Apr 23, 2024
@bpark1327
Copy link
Collaborator Author

@shorowit The 2024 data we saw yesterday was located in the "state-level profiles" (Not the SEDS). Upon further investigation, it seems to be sourced from the Navigators (the data source we have been using). I confirmed that the most recent data in the SEDS is from 2022. This appears to be the major issue with the SEDS. Do you think we should stick with what we've been using?

@shorowit
Copy link
Contributor

@bpark1327 That's unfortunate. I would probably still go with SEDS, it has all the fuel types we need and in a nice standardized format. All EIA data sources have some lag, so having a bit of a larger lag doesn't bother me too much.

@shorowit
Copy link
Contributor

And boy, their website is confusing. Thanks for figuring all of this out.

@bpark1327
Copy link
Collaborator Author

And boy, their website is confusing. Thanks for figuring all of this out.

Sure, honestly, it was a bit painful. 😉

@bpark1327 bpark1327 requested a review from shorowit May 24, 2024 04:17
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments/suggestions.

HPXMLtoOpenStudio/resources/unit_conversions.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/unit_conversions.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/utility_bills.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/utility_bills.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting close, but I think there's a bug and I see you introduced a new warning.

ReportUtilityBills/measure.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/utility_bills.rb Show resolved Hide resolved
@shorowit shorowit merged commit 2313eb9 into master May 27, 2024
7 checks passed
@shorowit shorowit deleted the eia_wood_price_data branch May 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants