-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIA SEDS Price Data #1656
EIA SEDS Price Data #1656
Conversation
…dio-HPXML into eia_wood_price_data
…o eia_wood_price_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through the PR checklist. Also, one initial comment below.
@nmerket @shorowit I observed a discrepancy in fuel prices between SEDS and each individual fuel page, except for electricity. I reached out to the EIA, and I received a response stating that they were surprised by the discrepancy. The individual mentioned that he would consult his colleagues who work on SEDS and update me if the SEDS team can provide any clarification. I'll keep you informed once I have more information. |
@shorowit The 2024 data we saw yesterday was located in the "state-level profiles" (Not the SEDS). Upon further investigation, it seems to be sourced from the Navigators (the data source we have been using). I confirmed that the most recent data in the SEDS is from 2022. This appears to be the major issue with the SEDS. Do you think we should stick with what we've been using? |
@bpark1327 That's unfortunate. I would probably still go with SEDS, it has all the fuel types we need and in a nice standardized format. All EIA data sources have some lag, so having a bit of a larger lag doesn't bother me too much. |
And boy, their website is confusing. Thanks for figuring all of this out. |
Sure, honestly, it was a bit painful. 😉 |
…o eia_wood_price_data
… residential sector coal consumption in the United States, and SEDS does not estimate a price.
…dio-HPXML into eia_wood_price_data
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
…L into eia_wood_price_data
…L into eia_wood_price_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments/suggestions.
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
…L into eia_wood_price_data
…o eia_wood_price_data # Conflicts: # HPXMLtoOpenStudio/measure.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting close, but I think there's a bug and I see you introduced a new warning.
…L into eia_wood_price_data
…efined two different places.
Pull Request Description
Replace individual fuel prices with EIA State Energy Data System (SEDS) prices
About SEDS: https://www.eia.gov/state/seds/
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml
) has been updatedSample files have been added/updated (openstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run