-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANSI 301-2022: Air Distribution System Leakage Split #1629
Open
bpark1327
wants to merge
21
commits into
master
Choose a base branch
from
ansi_301_2022_air_distribution_leakage_split
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ansi_301_2022_air_distribution_leakage_split
…//github.com/NREL/OpenStudio-HPXML into ansi_301_2022_air_distribution_leakage_split
…//github.com/NREL/OpenStudio-HPXML into ansi_301_2022_air_distribution_leakage_split
…o ansi_301_2022_air_distribution_leakage_split
…o ansi_301_2022_air_distribution_leakage_split
…//github.com/NREL/OpenStudio-HPXML into ansi_301_2022_air_distribution_leakage_split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When the air distribution system leakage split between the supply and return side is not measured, the air distribution system leakage to outdoors at 25 Pascal pressure difference shall be split equally between the supply and return side of the air distribution system with the leakage distributed evenly across the duct system.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run