Room by room calculations #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oom-by-room calculations with surfaces and spaces
yzhou601
commented
Dec 22, 2023
This comment was marked as resolved.
This comment was marked as resolved.
…nto room-by-room-sizing
yzhou601
force-pushed
the
room-by-room-sizing
branch
from
875a66d
to
1e27eff
Compare
…o room-by-room-sizing # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml
…dio-HPXML into mj8_reporting # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac_sizing.rb
…o room-by-room-sizing # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac_sizing.rb
…dio-HPXML into room-by-room-sizing
…dio-HPXML into zone_design_loads
…o room-by-room-sizing
…dio-HPXML into zone_design_loads
…o-HPXML into zone_design_loads
…x house045 skylight.
…o-HPXML into hpxml_subsurface_attrs
…o-HPXML into hpxml_subsurface_attrs # Conflicts: # HPXMLtoOpenStudio/measure.xml [ci skip]
Misc hpxml.rb cleanup
Zone design loads
shorowit
approved these changes
May 16, 2024
There was a problem hiding this comment.
I'm happy with this. Diffs are pretty minimal, and where they occur, are improvements. This PR has hung out for so long, I'm going to merge it. Thanks for all your contributions here, @yzhou601! Work on the space airflow assignments can occur in another PR.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add room by room sizing methodology from Manual J to workflow.
TODO:
--skip-simulationis used @shorowitChecklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updated @yzhou601openstudio tasks.rb update_hpxmls) @yzhou601HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb) @yzhou601openstudio tasks.rb update_measureshas been run