Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportUtilityBills: account for all production credit #1555

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Nov 15, 2023

Pull Request Description

An alternative to #1554.

We are using "PV" (e.g., "PV Credit", "PVCompensationType") where something more general like "Production" may be more appropriate. Is that OK, or should we make some changes/additions? Otherwise, because the battery/generator is behind the meter, we probably should either introduce a new "Other Credit" or sum against "Energy". The latter is probably preferred.

Therefore, the changes that need to happen are:

  • Battery or generator w/ no PV: assume it's "net metering". In this case, all credit goes to "Energy".
  • Battery or generator w/ PV: only allow "net metering" (according to PV compensation type). In this case, all credit goes to "PV Credit".

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson added the bug Something isn't working label Nov 15, 2023
@joseph-robertson joseph-robertson self-assigned this Nov 15, 2023
@joseph-robertson joseph-robertson changed the title ReportUtilityBills: allow detailed bill calcs for scheduled battery energy arbitrage ReportUtilityBills: account for all production credit Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant