Geb HVAC - variable speed systems #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
changed the title
…o geb-hvac-var-speed
… geb-hvac-var-speed
…o geb-hvac-var-speed
…o geb-hvac-var-speed
…o geb-hvac-var-speed
This comment was marked as outdated.
This comment was marked as outdated.
|
TODO:
|
…o geb-hvac-var-speed
…o geb-hvac-var-speed
|
Issue created: #1635 Is there anything else left here? |
|
@yzhou601 Get the CI tests passing? 😛 |
shorowit
reviewed
Mar 5, 2024
…o geb-hvac-var-speed # Conflicts: # workflow/tests/base_results/results_bills.csv
This reverts commit 6215263.
|
@jmaguire1 Could you take a look at Scott's comment and my doc changes to see if there's anything else to address? |
Just took a look at the latest in the documentation, thank you for cleaning that up! It looks good to me. |
shorowit
approved these changes
Mar 7, 2024
…o geb-hvac-var-speed # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_sizing.csv # workflow/tests/base_results/results_workflow_simulations1.csv # workflow/tests/base_results/results_workflow_simulations1_bills.csv
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add a csv path input for maximum capacity ratios. The variable speed system speed level will be capped by the ratio specified.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedtasks.rb)HPXMLtoOpenStudio/testsand/orworkflow/tests/hpxml_translator_test.rb)openstudio tasks.rb update_measureshas been run