Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modeling CFIS w/ a supplemental fan #1185

Merged
merged 36 commits into from
Oct 12, 2022
Merged

Allow modeling CFIS w/ a supplemental fan #1185

merged 36 commits into from
Oct 12, 2022

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 26, 2022 •
edited

Pull Request Description

Addresses #1029.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Sep 26, 2022
@shorowit shorowit mentioned this pull request Sep 26, 2022
Open
4 tasks
@shorowit shorowit added the enhancement New feature or request label Sep 27, 2022
@shorowit shorowit added this to the 1.5.0 milestone Sep 28, 2022
shorowit and others added 25 commits September 28, 2022 17:37
@shorowit
Initial model updates and sample file.
7f8adbf
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
b2848b4 
…o cfis_supplemental_fan

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Revert PTACHeating change.
731386c
@shorowit
Handle outdoor air impact of supplemental fan. (Still need to handle …
87ac9db 
…HRV/ERV effectiveness.)
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
cee898a 
…o cfis_supplemental_fan

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
Latest results.
74b7cf0
@shorowit
Fix tests.
7953bbe
@shorowit
Merge branch 'cfis_supplemental_fan' of https://github.com/NREL/OpenS…
978f93f 
…tudio-HPXML into cfis_supplemental_fan
@shorowit
First pass on applying sensible/latent effectiveness when the CFIS su…
7bef24e 
…pplemental fan is an ERV/HRV.
@shorowit
Bugfix.
77f7bce
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
8f50ae7 
…o cfis_supplemental_fan

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
Latest results.
0730955
@shorowit
Allow supply/exhaust systems only.
3a8fab0
@shorowit
Merge branch 'cfis_supplemental_fan' of https://github.com/NREL/OpenS…
59bdd4b 
…tudio-HPXML into cfis_supplemental_fan
@shorowit
Bugfixes. If CFIS supplemental fan is undersized, provide warning and…
423ec79 
… ensure supplemental fan RTF does not exceed 1.
@shorowit
Update tests.
00181ed
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
d87137a 
…o cfis_supplemental_fan

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	ReportHPXMLOutput/measure.xml
#	workflow/tests/base_results/results_hvac_sizing.csv
@shorowit
Update docs. [ci skip]
b1b5ec3
@shorowit
Fix tests.
481bd2f
Latest results.
5a8aabd
@shorowit
Bugfix.
bee1706
@shorowit
Update docs [ci skip]
96f08d3
Latest results.
45afda1
@shorowit
Update test.
e71eb1a
@shorowit
Update Changelog.md and docs. [ci skip]
9005fe1
@shorowit shorowit marked this pull request as ready for review October 5, 2022 14:31
@shorowit
Copy link
Contributor Author

shorowit commented Oct 5, 2022 •
edited

TODO:

  • Update input defaulting for supplemental fan; add tests in test_defaults.rb

@shorowit
Copy link
Contributor Author

shorowit commented Oct 6, 2022

Will do one more pass w/ the HPXML WG, otherwise this is ready to merge.

shorowit and others added 8 commits October 10, 2022 16:05
@shorowit
Add CFIS definition/description. [ci skip]
d1bea4e
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
9c61140 
…o cfis_supplemental_fan

# Conflicts:
#	Changelog.md
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
Latest results.
bb4e326
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
bd30d3e 
…o cfis_supplemental_fan

# Conflicts:
#	Changelog.md
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hpxml_schema/HPXMLDataTypes.xsd
#	ReportHPXMLOutput/measure.xml
#	ReportSimulationOutput/measure.xml
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_hvac_sizing.csv
Latest results.
1138d10
@shorowit
Adds error-checking around HoursInOperation specified for a CFIS supp…
0e95078 
…lemental fan.
@shorowit
Merge branch 'cfis_supplemental_fan' of https://github.com/NREL/OpenS…
f66159a 
…tudio-HPXML into cfis_supplemental_fan
@shorowit
Update docs
9071be5
@shorowit shorowit added this to In progress in OpenStudio-HPXML via automation Oct 12, 2022
@shorowit shorowit merged commit 253c6b2 into master Oct 12, 2022
OpenStudio-HPXML automation moved this from In progress to Done Oct 12, 2022
@shorowit shorowit deleted the cfis_supplemental_fan branch October 12, 2022 00:19
@joseph-robertson joseph-robertson mentioned this pull request Oct 13, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
enhancement New feature or request
Projects
OpenStudio-HPXML
Archived in project
OpenStudio-HPXML
Done
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shorowit