Duct shape inputs #729
Merged
Duct shape inputs #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1532d17b68 Shift a few more runs. eadb929401 Latest results. 82edf31ad0 Add sample files, some more tests. a57b3bef9f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into duct_shape f243e9275c Latest results. 0a8c8aba15 Bump tolerance a bit. 373355001b First pass. git-subtree-dir: hpxml-measures git-subtree-split: 1532d17b68a960a157906944dfcbdf5ac32ea1e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allows optional
Ducts/DuctShapeandDucts/DuctFractionRectangularinputs, which affect duct effective R-value used for modeling.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Workflow tests have been updatedopenstudio tasks.rb update_measureshas been run