Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose HVAC Detailed Performance Data inputs #715

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Expose HVAC Detailed Performance Data inputs #715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
758b4f8
first pass
bpark1327 Feb 7, 2024
dab6e6f
Cleanup 301 validator; Select the minimum set of files for testing
bpark1327 Feb 22, 2024
be809f1
Add detailed performance data only for system types that allow detail…
bpark1327 Feb 22, 2024
34335e3
run tasks.rb update_measure
bpark1327 Feb 22, 2024
5323228
Bugfix
bpark1327 Feb 26, 2024
724623f
Latest results.
Feb 26, 2024
7e458a9
remove unnecessary sample files
bpark1327 Feb 28, 2024
0563af5
update validator and clean up 301 ruleset
bpark1327 Feb 28, 2024
aa7be92
Merge branch 'expose_hvac_detailed_perf_inputs' of github.com:NREL/Op…
bpark1327 Feb 28, 2024
2238de2
Merge branch 'latest-os-hpxml' of github.com:NREL/OpenStudio-ERI into…
bpark1327 Feb 28, 2024
c690cd6
Latest results.
Feb 29, 2024
16ef057
update documentation and changelog
bpark1327 Mar 6, 2024
4d6997a
Merge branch 'expose_hvac_detailed_perf_inputs' of github.com:NREL/Op…
bpark1327 Mar 6, 2024
83c9f54
Merge branch 'latest-os-hpxml' of github.com:NREL/OpenStudio-ERI into…
bpark1327 Mar 6, 2024
f68a9a7
Latest results.
Mar 6, 2024
c6beb5d
cleanup 301validator, workflow_inputs doc and add tests
bpark1327 Mar 9, 2024
36c3179
Merge branch 'expose_hvac_detailed_perf_inputs' of github.com:NREL/Op…
bpark1327 Mar 9, 2024
863fb54
Merge branch 'latest-os-hpxml' of github.com:NREL/OpenStudio-ERI into…
bpark1327 Mar 9, 2024
e56b559
Latest results.
Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 19 additions & 2 deletions rulesets/resources/301ruleset.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,13 @@ def self.set_systems_hvac_rated(orig_bldg, new_bldg)
integrated_heating_system_capacity: orig_cooling_system.integrated_heating_system_capacity,
integrated_heating_system_efficiency_percent: orig_cooling_system.integrated_heating_system_efficiency_percent,
integrated_heating_system_fraction_heat_load_served: orig_cooling_system.integrated_heating_system_fraction_heat_load_served,
htg_seed_id: htg_seed_id)
htg_seed_id: htg_seed_id,
hvac_perf_data_capacity_type: orig_cooling_system.hvac_perf_data_capacity_type,
hvac_perf_data_cooling_outdoor_temperatures: orig_cooling_system.hvac_perf_data_cooling_outdoor_temperatures,
hvac_perf_data_cooling_min_speed_capacities: orig_cooling_system.hvac_perf_data_cooling_min_speed_capacities,
hvac_perf_data_cooling_max_speed_capacities: orig_cooling_system.hvac_perf_data_cooling_max_speed_capacities,
hvac_perf_data_cooling_min_speed_cops: orig_cooling_system.hvac_perf_data_cooling_min_speed_cops,
hvac_perf_data_cooling_max_speed_cops: orig_cooling_system.hvac_perf_data_cooling_max_speed_cops)
end
# Add reference cooling system for residual load
if (sum_frac_cool_load < 0.99) # Accommodate systems that don't quite sum to 1 due to rounding
Expand Down Expand Up @@ -1363,7 +1369,18 @@ def self.set_systems_hvac_rated(orig_bldg, new_bldg)
airflow_defect_ratio: airflow_defect_ratio,
charge_defect_ratio: charge_defect_ratio,
htg_seed_id: orig_heat_pump.htg_seed_id.nil? ? orig_heat_pump.id : orig_heat_pump.htg_seed_id,
clg_seed_id: orig_heat_pump.clg_seed_id.nil? ? orig_heat_pump.id : orig_heat_pump.clg_seed_id)
clg_seed_id: orig_heat_pump.clg_seed_id.nil? ? orig_heat_pump.id : orig_heat_pump.clg_seed_id,
hvac_perf_data_capacity_type: orig_heat_pump.hvac_perf_data_capacity_type,
hvac_perf_data_heating_outdoor_temperatures: orig_heat_pump.hvac_perf_data_heating_outdoor_temperatures,
hvac_perf_data_heating_min_speed_capacities: orig_heat_pump.hvac_perf_data_heating_min_speed_capacities,
hvac_perf_data_heating_max_speed_capacities: orig_heat_pump.hvac_perf_data_heating_max_speed_capacities,
hvac_perf_data_heating_min_speed_cops: orig_heat_pump.hvac_perf_data_heating_min_speed_cops,
hvac_perf_data_heating_max_speed_cops: orig_heat_pump.hvac_perf_data_heating_max_speed_cops,
hvac_perf_data_cooling_outdoor_temperatures: orig_heat_pump.hvac_perf_data_cooling_outdoor_temperatures,
hvac_perf_data_cooling_min_speed_capacities: orig_heat_pump.hvac_perf_data_cooling_min_speed_capacities,
hvac_perf_data_cooling_max_speed_capacities: orig_heat_pump.hvac_perf_data_cooling_max_speed_capacities,
hvac_perf_data_cooling_min_speed_cops: orig_heat_pump.hvac_perf_data_cooling_min_speed_cops,
hvac_perf_data_cooling_max_speed_cops: orig_heat_pump.hvac_perf_data_cooling_max_speed_cops)
end
# Add reference heat pump for residual load
if (not has_fuel) && (sum_frac_heat_load < 0.99) # Accommodate systems that don't quite sum to 1 due to rounding
Expand Down
42 changes: 42 additions & 0 deletions rulesets/resources/301validator.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ Temporarily disabled until RESNET allows this.
<sch:assert role='ERROR' test='count(h:AnnualCoolingEfficiency[h:Units="SEER" or h:Units="SEER2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualCoolingEfficiency[Units="SEER" or Units="SEER2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:SensibleHeatFraction) &lt;= 1'>Expected 0 or 1 element(s) for xpath: SensibleHeatFraction</sch:assert>
<sch:assert role='ERROR' test='number(h:SensibleHeatFraction) &gt; 0.5 or not(h:SensibleHeatFraction)'>Expected SensibleHeatFraction to be greater than 0.5</sch:assert>
<sch:assert role='ERROR' test='count(h:CoolingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: CoolingDetailedPerformanceData</sch:assert> <!-- See [CoolingDetailedPerformanceData]-->
<sch:assert role='ERROR' test='count(h:IntegratedHeatingSystemFuel) = 0'>Expected 0 element(s) for xpath: IntegratedHeatingSystemFuel</sch:assert>
<sch:assert role='ERROR' test='count(h:extension/h:FanPowerWattsPerCFM) = 1'>Expected 1 element(s) for xpath: extension/FanPowerWattsPerCFM</sch:assert>
<sch:assert role='ERROR' test='number(h:extension/h:FanPowerWattsPerCFM) &gt;= 0 or not(h:extension/h:FanPowerWattsPerCFM)'>Expected extension/FanPowerWattsPerCFM to be greater than or equal to 0</sch:assert>
Expand Down Expand Up @@ -756,6 +757,7 @@ Temporarily disabled until RESNET allows this.
<sch:assert role='ERROR' test='count(h:AnnualCoolingEfficiency[h:Units="SEER" or h:Units="SEER2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualCoolingEfficiency[Units="SEER" or Units="SEER2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:SensibleHeatFraction) &lt;= 1'>Expected 0 or 1 element(s) for xpath: SensibleHeatFraction</sch:assert>
<sch:assert role='ERROR' test='number(h:SensibleHeatFraction) &gt; 0.5 or not(h:SensibleHeatFraction)'>Expected SensibleHeatFraction to be greater than 0.5</sch:assert>
<sch:assert role='ERROR' test='count(h:CoolingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: CoolingDetailedPerformanceData</sch:assert> <!-- See [CoolingDetailedPerformanceData]-->
<sch:assert role='ERROR' test='count(h:IntegratedHeatingSystemFuel) = 0'>Expected 0 element(s) for xpath: IntegratedHeatingSystemFuel</sch:assert>
<sch:assert role='ERROR' test='count(h:extension/h:FanPowerWattsPerCFM) = 1'>Expected 1 element(s) for xpath: extension/FanPowerWattsPerCFM</sch:assert>
<sch:assert role='ERROR' test='number(h:extension/h:FanPowerWattsPerCFM) &gt;= 0 or not(h:extension/h:FanPowerWattsPerCFM)'>Expected extension/FanPowerWattsPerCFM to be greater than or equal to 0</sch:assert>
Expand Down Expand Up @@ -867,6 +869,8 @@ Temporarily disabled until RESNET allows this.
<sch:assert role='ERROR' test='count(h:FractionCoolLoadServed) = 1'>Expected 1 element(s) for xpath: FractionCoolLoadServed</sch:assert>
<sch:assert role='ERROR' test='count(h:AnnualCoolingEfficiency[h:Units="SEER" or h:Units="SEER2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualCoolingEfficiency[Units="SEER" or Units="SEER2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:AnnualHeatingEfficiency[h:Units="HSPF" or h:Units="HSPF2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualHeatingEfficiency[Units="HSPF" or Units="HSPF2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:CoolingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: CoolingDetailedPerformanceData</sch:assert> <!-- See [CoolingDetailedPerformanceData] -->
<sch:assert role='ERROR' test='count(h:HeatingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: HeatingDetailedPerformanceData</sch:assert> <!-- See [HeatingDetailedPerformanceData] -->
<sch:assert role='ERROR' test='count(h:extension/h:FanPowerWattsPerCFM) = 1'>Expected 1 element(s) for xpath: extension/FanPowerWattsPerCFM</sch:assert>
<sch:assert role='ERROR' test='number(h:extension/h:FanPowerWattsPerCFM) &gt;= 0 or not(h:extension/h:FanPowerWattsPerCFM)'>Expected extension/FanPowerWattsPerCFM to be greater than or equal to 0</sch:assert>
<sch:assert role='ERROR' test='count(h:extension/h:AirflowDefectRatio) = 1'>Expected 1 element(s) for xpath: extension/AirflowDefectRatio</sch:assert> <!-- See [AirflowDefectRatio] -->
Expand Down Expand Up @@ -899,6 +903,8 @@ Temporarily disabled until RESNET allows this.
<sch:assert role='ERROR' test='count(h:FractionCoolLoadServed) = 1'>Expected 1 element(s) for xpath: FractionCoolLoadServed</sch:assert>
<sch:assert role='ERROR' test='count(h:AnnualCoolingEfficiency[h:Units="SEER" or h:Units="SEER2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualCoolingEfficiency[Units="SEER" or Units="SEER2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:AnnualHeatingEfficiency[h:Units="HSPF" or h:Units="HSPF2"]/h:Value) = 1'>Expected 1 element(s) for xpath: AnnualHeatingEfficiency[Units="HSPF" or Units="HSPF2"]/Value</sch:assert>
<sch:assert role='ERROR' test='count(h:CoolingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: CoolingDetailedPerformanceData</sch:assert> <!-- See [CoolingDetailedPerformanceData] -->
<sch:assert role='ERROR' test='count(h:HeatingDetailedPerformanceData) &lt;= 1'>Expected 0 or 1 element(s) for xpath: HeatingDetailedPerformanceData</sch:assert> <!-- See [HeatingDetailedPerformanceData] -->
<sch:assert role='ERROR' test='count(h:extension/h:FanPowerWattsPerCFM) = 1'>Expected 1 element(s) for xpath: extension/FanPowerWattsPerCFM</sch:assert>
<sch:assert role='ERROR' test='number(h:extension/h:FanPowerWattsPerCFM) &gt;= 0 or not(h:extension/h:FanPowerWattsPerCFM)'>Expected extension/FanPowerWattsPerCFM to be greater than or equal to 0</sch:assert>
<sch:assert role='ERROR' test='count(h:extension/h:AirflowDefectRatio) = 1'>Expected 1 element(s) for xpath: extension/AirflowDefectRatio</sch:assert> <!-- See [AirflowDefectRatio] -->
Expand Down Expand Up @@ -1024,6 +1030,42 @@ Temporarily disabled until RESNET allows this.
</sch:rule>
</sch:pattern>

<sch:pattern>
<sch:title>[HeatingDetailedPerformanceData]</sch:title>
<sch:rule context='/h:HPXML/h:Building/h:BuildingDetails/h:Systems/h:HVAC/h:HVACPlant/*/h:HeatingDetailedPerformanceData'>
<sch:assert role='ERROR' test='count(../h:CompressorType[text()="variable speed"]) = 1'>Expected 1 element(s) for xpath: ../CompressorType[text()="variable speed"]</sch:assert>
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=47 and h:CapacityDescription="minimum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=47 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=47 and h:CapacityDescription="maximum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=47 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=47 and h:CapacityDescription="minimum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=47 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=47 and h:CapacityDescription="maximum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=47 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
</sch:rule>
</sch:pattern>

<sch:pattern>
<sch:title>[CoolingDetailedPerformanceData]</sch:title>
<sch:rule context='/h:HPXML/h:Building/h:BuildingDetails/h:Systems/h:HVAC/h:HVACPlant/*/h:CoolingDetailedPerformanceData'>
<sch:assert role='ERROR' test='count(../h:CompressorType[text()="variable speed"]) = 1'>Expected 1 element(s) for xpath: ../CompressorType[text()="variable speed"]</sch:assert>
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=95 and h:CapacityDescription="minimum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=95 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=95 and h:CapacityDescription="maximum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=95 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=95 and h:CapacityDescription="minimum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=95 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
<sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=95 and h:CapacityDescription="maximum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=95 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
bpark1327 marked this conversation as resolved.
Show resolved Hide resolved
</sch:rule>
</sch:pattern>

<sch:pattern>
<sch:title>[HeatingDetailedPerformanceDataPointWithCapacity]</sch:title>
<sch:rule context='/h:HPXML/h:Building/h:BuildingDetails/h:Systems/h:HVAC/h:HVACPlant/*/h:HeatingDetailedPerformanceData/h:PerformanceDataPoint/h:Capacity'>
<sch:assert role='ERROR' test='count(../../../h:HeatingCapacity) = 1'>Expected 1 element(s) for xpath: ../../../HeatingCapacity</sch:assert>
</sch:rule>
</sch:pattern>

<sch:pattern>
<sch:title>[CoolingDetailedPerformanceDataPointWithCapacity]</sch:title>
<sch:rule context='/h:HPXML/h:Building/h:BuildingDetails/h:Systems/h:HVAC/h:HVACPlant/*/h:CoolingDetailedPerformanceData/h:PerformanceDataPoint/h:Capacity'>
<sch:assert role='ERROR' test='count(../../../h:CoolingCapacity) = 1'>Expected 1 element(s) for xpath: ../../../CoolingCapacity</sch:assert>
</sch:rule>
</sch:pattern>
bpark1327 marked this conversation as resolved.
Show resolved Hide resolved

<sch:pattern>
<sch:title>[AirflowDefectRatio]</sch:title>
<sch:rule context='/h:HPXML/h:Building/h:BuildingDetails/h:Systems/h:HVAC/h:HVACPlant/*[not(h:DistributionSystem)]'>
Expand Down
14 changes: 14 additions & 0 deletions tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2424,6 +2424,20 @@ def create_sample_hpxmls
'base-hvac-air-to-air-heat-pump-1-speed-seer2-hspf2.xml',
'base-hvac-air-to-air-heat-pump-2-speed.xml',
'base-hvac-air-to-air-heat-pump-var-speed.xml',
'base-hvac-air-to-air-heat-pump-var-speed-detailed-performance.xml',
'base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-heating-only.xml',
'base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-normalized-capacities.xml',
'base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-autosize.xml',
'base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-other-temperatures.xml',
'base-hvac-central-ac-only-var-speed-detailed-performance.xml',
'base-hvac-central-ac-only-var-speed-detailed-performance-autosize.xml',
'base-hvac-install-quality-air-to-air-heat-pump-var-speed-detailed-performance.xml',
'base-hvac-mini-split-air-conditioner-only-ductless-detailed-performance.xml',
'base-hvac-mini-split-air-conditioner-only-ductless-detailed-performance-autosize.xml',
'base-hvac-mini-split-heat-pump-ducted-detailed-performance.xml',
'base-hvac-mini-split-heat-pump-ducted-detailed-performance-autosize.xml',
'base-hvac-mini-split-heat-pump-ductless-detailed-performance.xml',
'base-hvac-mini-split-heat-pump-ductless-detailed-performance-autosize.xml',
bpark1327 marked this conversation as resolved.
Show resolved Hide resolved
'base-hvac-boiler-elec-only.xml',
'base-hvac-boiler-gas-only.xml',
'base-hvac-boiler-oil-only.xml',
Expand Down