Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow diagnostic output #678

Draft
wants to merge 24 commits into
base: latest-os-hpxml
Choose a base branch
from
Draft

Allow diagnostic output #678

wants to merge 24 commits into from

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented May 10, 2023 •
edited

Pull Request Description

Adds a --diagnostic-output command-line argument to produce a diagnostic output file per the HERS Diagnostic Output Schema. Updated for v0.2.0.

TODO:

  • Update it to work with JSON output files or require csv output
  • Handle dual-fuel systems
  • Handle dehumidifiers

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@shorowit shorowit self-assigned this May 10, 2023
@shorowit shorowit changed the base branch from master to latest-os-hpxml2 May 10, 2023 00:40
Base automatically changed from latest-os-hpxml2 to master May 23, 2023 04:08
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
b797d08 
 into diagnostic_output3

# Conflicts:
#	Gemfile.lock
#	workflow/design.rb
#	workflow/energy_rating_index.rb
#	workflow/tests/base_results/real_homes.csv
#	workflow/tests/util.rb
#	workflow/tests/workflow_test.rb
@shorowit shorowit changed the base branch from master to latest-os-hpxml April 8, 2024 21:17
@shorowit
Bugfix.
60f164f
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
3fd0963 
 into diagnostic_output3

# Conflicts:
#	workflow/tests/base_results/real_homes.csv
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
3c6cd5a 
 into diagnostic_output3

# Conflicts:
#	Gemfile.lock
#	workflow/tests/base_results/real_homes.csv
@shorowit
Bump to final OS 3.8
87dbde3
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
9c8e9e7 
 into diagnostic_output3

# Conflicts:
#	workflow/tests/base_results/real_homes.csv
@shorowit
Squashed 'hpxml-measures/' changes from f5b5c0ea68..6deaa23444
9a53ac9 
6deaa23444 Update Changelog.md
e02ba50e2f Align timeseries EC_adj with hot water energy use.

git-subtree-dir: hpxml-measures
git-subtree-split: 6deaa23444f93d69190166d7e1309e2eb606a4da
@shorowit
Merge commit '9a53ac91d4f39dc2102d6c9e9111cff7b85e354b' into diagnost…
973917b 
…ic_output3
@shorowit
Squashed 'hpxml-measures/' changes from 6deaa23444..eb50a8eeaa
9a8972b 
eb50a8eeaa Handle warmup period.

git-subtree-dir: hpxml-measures
git-subtree-split: eb50a8eeaa67ffc394ad6db88eaf8ebebc1faf66
@shorowit
Merge commit '9a8972bbb344e411745d15e20fa80a4fa999a72b' into diagnost…
792d3df 
…ic_output3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shorowit