Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Improvements #86

Merged
merged 3 commits into from
Nov 6, 2023
Merged

User Improvements #86

merged 3 commits into from
Nov 6, 2023

Conversation

mnblonsky
Copy link
Collaborator

@mnblonsky mnblonsky commented Oct 18, 2023

Addresses #85.

  • Added error for very short duration simulations

  • Added OCHREException to handle errors

  • Updated docs and added trademark logo

  • Reference the issue your PR is fixing

  • Assign at least 1 reviewer for your PR

  • Test with run_dwelling.py or other script

  • Update documentation as appropriate

  • Update changelog as appropriate

@mnblonsky mnblonsky self-assigned this Oct 18, 2023
@jmaguire1 jmaguire1 self-requested a review October 19, 2023 20:58
Copy link
Collaborator

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the OCHREException class. Sorry it took me so long to review.

@jmaguire1 jmaguire1 merged commit 688985c into dev Nov 6, 2023
@jmaguire1 jmaguire1 deleted the user-improvements branch November 6, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants