Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More descriptive errors when running a single timestep #85

Open
jmaguire1 opened this issue Oct 17, 2023 · 0 comments
Open

More descriptive errors when running a single timestep #85

jmaguire1 opened this issue Oct 17, 2023 · 0 comments
Assignees
@mnblonsky @jmaguire1
Labels
bug Something isn't working Medium Priority

Comments

@jmaguire1
Copy link
Collaborator

Sathya spotted this one. If you try to run just a single timestep with OCHRE, you'll get an error in the schedule file because it's looking for at least 2 timesteps of schedule data to be available. We should at a minimum look at adding a more descriptive error here, Sathya was seeing all sorts of different errors with different input files that made this hard to track down.
@jmaguire1 jmaguire1 added bug Something isn't working Medium Priority labels Oct 17, 2023
@mnblonsky mnblonsky mentioned this issue Oct 18, 2023
Merged
5 tasks
jmaguire1 added a commit that referenced this issue Nov 6, 2023
@jmaguire1
User Improvements (#86)
688985c 
Addresses #85.

- Added error for very short duration simulations
- Added OCHREException to handle errors
- Updated docs and added trademark logo

- [x] Reference the issue your PR is fixing
- [x] Assign at least 1 reviewer for your PR
- [x] Test with run_dwelling.py or other script
- [x] Update documentation as appropriate
- [x] Update changelog as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnblonsky mnblonsky

@jmaguire1 jmaguire1

Labels
bug Something isn't working Medium Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnblonsky @jmaguire1