Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenheart MPI #316

Merged
merged 6 commits into from
May 14, 2024
Merged

Conversation

jaredthomas68
Copy link
Collaborator

Enable OpenMDAO MPI capabilities for GreenHEART

This PR enables users to leverage the MPI capabilities of GreenHEART to use parallel finite differencing during optimization and run cases in parallel during a design of experiments.

Related issue

Impacted areas of the software

greenheart

Additional supporting information

The necessary installation steps to run in parallel are the same as for OpenMDAO

Test results, if applicable

No added or changed tests

Copy link
Collaborator

@kbrunik kbrunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a little redundancy with PR #315 so let's be sure to get that in first. No major comments but would be good to address before pulling this in

@@ -1,16 +1,21 @@
"""
This file is based on the WISDEM file of the same name: https://github.com/WISDEM/WISDEM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think WISDEM has a file called gc_run_greenheart?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fixed. Thanks

@@ -28,35 +33,40 @@ def run_greenheart(config:GreenHeartSimulationConfig, overridden_values=None, ru
# Otherwise, initialize the WindPark system normally. Get the rank number for parallelization. We only print output files using the root processor.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to update this comment since I'm not sure if it's the WindPark system we are parallelizing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I have updated the comment.

@jaredthomas68 jaredthomas68 merged commit 4abc512 into NREL:greensteel-eco-sync May 14, 2024
4 checks passed
@jaredthomas68 jaredthomas68 deleted the greenheart-mpi branch May 14, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants