Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom financial model dictionary input form #289

Merged

Conversation

bayc
Copy link
Collaborator

@bayc bayc commented Mar 15, 2024

Expand custom_financial_model to use a more well-defined dictionary and utilize defaults for the default_fin_config

This PR updates custom_financial_model to use a dictionary that separates the configuration dictionary by technology. It also established default values within the code so the user does not have to supply the default_fin_config.yaml explicitly, with the one exception being the financial_parameters. This simplifies setup and more easily enables a user to update specific parts of the default financial configuration for different technologies.

Related issue

#284

Impacted areas of the software

custom_financial_model.py
Tests

Additional supporting information

This method still requires the user to specify a dictionary to use the custom financial model. In the inputs files, where we don't want to specify the input explicitly or point to a yaml file, the user will need to supply at the bare minimum a financial_parameters dictionary with both inflation_rate and real_discount_rate defined, as shown below.

financial_parameters:
  inflation_rate: 2.5
  real_discount_rate: 6.4

Test results, if applicable

Tests are passing.

@bayc bayc added enhancement New feature or request refactor Associated with the refactor of HOPP labels Mar 15, 2024
@bayc bayc self-assigned this Mar 15, 2024
Copy link
Collaborator

@jaredthomas68 jaredthomas68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jaredthomas68 jaredthomas68 merged commit 097812e into NREL:greensteel-eco-sync Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Associated with the refactor of HOPP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants