fix(curriculum): Update description for Step 1 of the Luhn Algorithm …

…project (freeCodeCamp#54733)
MohamedRahimm · May 15, 2024 · 64b161c · 64b161c
2 parents 4b4f9ad + 98e5ac1
commit 64b161c
Show file tree

Hide file tree

Showing 222 changed files with 4,734 additions and 1,043 deletions.
diff --git a/client/i18n/locales/english/intro.json b/client/i18n/locales/english/intro.json
@@ -472,6 +472,13 @@
           "In this mini project, you will get to review JavaScript fundamentals like functions, variables, conditionals and more by building a gradebook app.",
           "This will give you an opportunity to solve small problems and get a better understanding of the basics."
         ]
+      },
+      "review-dom-manipulation-by-building-a-rock-paper-scissors-game": {
+        "title": "Review DOM Manipulation by Building a Rock, Paper, Scissors Game",
+        "intro": [
+          "In the previous projects you learned how to work with basic DOM manipulation. Now it is time to review what you have learned by building a Rock, Paper, Scissors game.",
+          "In this mini project, you will review conditionals, functions, <code>getElementById</code>, and more. This project will give you an opportunity to solve small problems and get a better understanding of the basics."
+        ]
       }
     }
   },

diff --git a/client/i18n/locales/english/translations.json b/client/i18n/locales/english/translations.json
@@ -72,7 +72,11 @@
     "update-email": "Update my Email",
     "verify-email": "Verify Email",
     "submit-and-go": "Submit and go to next challenge",
+    "submit-and-go-2": "Submit and go to next challenge (Ctrl + Enter)",
+    "submit-and-go-3": "Submit and go to next challenge (Command + Enter)",
     "go-to-next": "Go to next challenge",
+    "go-to-next-2": "Go to next challenge (Ctrl + Enter)",
+    "go-to-next-3": "Go to next challenge (Command + Enter)",
     "ask-later": "Ask me later",
     "start-coding": "Start coding!",
     "go-to-settings": "Go to settings to claim your certification",
@@ -293,8 +297,6 @@
     }
   },
   "profile": {
-    "you-not-public": "You have not made your portfolio public.",
-    "username-not-public": "{{username}} has not made their portfolio public.",
     "you-change-privacy": "You need to change your privacy setting in order for your portfolio to be seen by others. This is a preview of how your portfolio will look when made public.",
     "username-change-privacy": "{{username}} needs to change their privacy setting in order for you to view their portfolio.",
     "supporter": "Supporter",

diff --git a/client/src/components/profile/components/camper.tsx b/client/src/components/profile/components/camper.tsx
@@ -60,7 +60,7 @@ function Camper({
       </div>
       {(isDonating || isTopContributor) && (
         <FullWidthRow>
-          <h2 className='text-center'>{t('profile.badges')}</h2>
+          <h2>{t('profile.badges')}</h2>
           <div className='badge-card-container'>
             {isDonating && (
               <div className='badge-card'>

diff --git a/client/src/components/profile/profile.tsx b/client/src/components/profile/profile.tsx
@@ -3,7 +3,7 @@ import Helmet from 'react-helmet';
 import type { TFunction } from 'i18next';
 import { useTranslation } from 'react-i18next';
 
-import { Container, Row } from '@freecodecamp/ui';
+import { Alert, Container, Row } from '@freecodecamp/ui';
 import { FullWidthRow, Link, Spacer } from '../helpers';
 import { User } from './../../redux/prop-types';
 import Timeline from './components/time-line';
@@ -26,8 +26,7 @@ interface MessageProps {
 const UserMessage = ({ t }: Pick<MessageProps, 't'>) => {
   return (
     <FullWidthRow>
-      <h2 className='text-center'>{t('profile.you-not-public')}</h2>
-      <p className='alert alert-info'>{t('profile.you-change-privacy')}</p>
+      <Alert variant='info'>{t('profile.you-change-privacy')}</Alert>
       <Spacer size='medium' />
     </FullWidthRow>
   );
@@ -39,12 +38,9 @@ const VisitorMessage = ({
 }: Omit<MessageProps, 'isSessionUser'>) => {
   return (
     <FullWidthRow>
-      <h2 className='text-center' style={{ overflowWrap: 'break-word' }}>
-        {t('profile.username-not-public', { username: username })}
-      </h2>
-      <p className='alert alert-info'>
-        {t('profile.username-change-privacy', { username: username })}
-      </p>
+      <Alert variant='info'>
+        {t('profile.username-change-privacy', { username })}
+      </Alert>
       <Spacer size='medium' />
     </FullWidthRow>
   );

diff --git a/...ures-v8/review-dom-manipulation-by-building-a-rock-paper-scissors-game/index.md b/...ures-v8/review-dom-manipulation-by-building-a-rock-paper-scissors-game/index.md
@@ -0,0 +1,9 @@
+---
+title: Introduction to the Review DOM Manipulation by Building a Rock, Paper, Scissors Game
+block: review-dom-manipulation-by-building-a-rock-paper-scissors-game
+superBlock: javascript-algorithms-and-data-structures-v8
+---
+
+## Introduction to the Review DOM Manipulation by Building a Rock, Paper, Scissors Game
+
+This is a test for the new project-based curriculum.
diff --git a/client/src/templates/Challenges/components/completion-modal.tsx b/client/src/templates/Challenges/components/completion-modal.tsx
@@ -25,7 +25,7 @@ import {
 import Progress from '../../../components/Progress';
 import GreenPass from '../../../assets/icons/green-pass';
 import { Spacer } from '../../../components/helpers';
-
+import { MAX_MOBILE_WIDTH } from '../../../../config/misc';
 import './completion-modal.css';
 import callGA from '../../../analytics/call-ga';
 
@@ -166,6 +166,25 @@ class CompletionModal extends Component<
 
     const isMacOS = navigator.userAgent.includes('Mac OS');
 
+    const isDesktop = window.innerWidth > MAX_MOBILE_WIDTH;
+
+    let buttonText;
+    if (isDesktop) {
+      if (isMacOS) {
+        buttonText = isSignedIn
+          ? t('buttons.submit-and-go-3')
+          : t('buttons.go-to-next-3');
+      } else {
+        buttonText = isSignedIn
+          ? t('buttons.submit-and-go-2')
+          : t('buttons.go-to-next-2');
+      }
+    } else {
+      buttonText = isSignedIn
+        ? t('buttons.submit-and-go')
+        : t('buttons.go-to-next');
+    }
+
     return (
       <Modal
         onClose={close}
@@ -200,10 +219,7 @@ class CompletionModal extends Component<
             data-cy='submit-challenge'
             onClick={() => submitChallenge()}
           >
-            {isSignedIn ? t('buttons.submit-and-go') : t('buttons.go-to-next')}
-            <span className='hidden-xs'>
-              {isMacOS ? ' (Command + Enter)' : ' (Ctrl + Enter)'}
-            </span>
+            {buttonText}
           </Button>
           <Spacer size='xxSmall' />
           {this.state.downloadURL ? (

diff --git a/curriculum/challenges/_meta/build-a-cash-register-project/meta.json b/curriculum/challenges/_meta/build-a-cash-register-project/meta.json
@@ -4,7 +4,7 @@
   "dashedName": "build-a-cash-register-project",
   "usesMultifileEditor": true,
   "helpCategory": "JavaScript",
-  "order": 19,
+  "order": 20,
   "time": "30 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/build-a-palindrome-checker-project/meta.json b/curriculum/challenges/_meta/build-a-palindrome-checker-project/meta.json
@@ -4,7 +4,7 @@
   "dashedName": "build-a-palindrome-checker-project",
   "usesMultifileEditor": true,
   "helpCategory": "JavaScript",
-  "order": 6,
+  "order": 7,
   "time": "30 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/build-a-pokemon-search-app-project/meta.json b/curriculum/challenges/_meta/build-a-pokemon-search-app-project/meta.json
@@ -4,7 +4,7 @@
   "dashedName": "build-a-pokemon-search-app-project",
   "usesMultifileEditor": true,
   "helpCategory": "JavaScript",
-  "order": 22,
+  "order": 23,
   "time": "30 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/build-a-roman-numeral-converter-project/meta.json b/curriculum/challenges/_meta/build-a-roman-numeral-converter-project/meta.json
@@ -4,7 +4,7 @@
   "dashedName": "build-a-roman-numeral-converter-project",
   "usesMultifileEditor": true,
   "helpCategory": "JavaScript",
-  "order": 10,
+  "order": 11,
   "time": "30 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/build-a-telephone-number-validator-project/meta.json b/curriculum/challenges/_meta/build-a-telephone-number-validator-project/meta.json
@@ -4,7 +4,7 @@
   "dashedName": "build-a-telephone-number-validator-project",
   "usesMultifileEditor": true,
   "helpCategory": "JavaScript",
-  "order": 15,
+  "order": 16,
   "time": "30 hours",
   "template": "",
   "required": [],

diff --git a/...allenges/_meta/learn-advanced-array-methods-by-building-a-statistics-calculator/meta.json b/...allenges/_meta/learn-advanced-array-methods-by-building-a-statistics-calculator/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-advanced-array-methods-by-building-a-statistics-calculator",
   "helpCategory": "JavaScript",
-  "order": 13,
+  "order": 14,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/...enges/_meta/learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/meta.json b/...enges/_meta/learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard",
   "helpCategory": "JavaScript",
-  "order": 21,
+  "order": 22,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/...m/challenges/_meta/learn-basic-algorithmic-thinking-by-building-a-number-sorter/meta.json b/...m/challenges/_meta/learn-basic-algorithmic-thinking-by-building-a-number-sorter/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-basic-algorithmic-thinking-by-building-a-number-sorter",
   "helpCategory": "JavaScript",
-  "order": 12,
+  "order": 13,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/learn-basic-oop-by-building-a-shopping-cart/meta.json b/curriculum/challenges/_meta/learn-basic-oop-by-building-a-shopping-cart/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-basic-oop-by-building-a-shopping-cart",
   "helpCategory": "JavaScript",
-  "order": 16,
+  "order": 17,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/...hallenges/_meta/learn-basic-string-and-array-methods-by-building-a-music-player/meta.json b/...hallenges/_meta/learn-basic-string-and-array-methods-by-building-a-music-player/meta.json
@@ -4,7 +4,7 @@
   "usesMultifileEditor": true,
   "hasEditableBoundaries": true,
   "dashedName": "learn-basic-string-and-array-methods-by-building-a-music-player",
-  "order": 4,
+  "order": 5,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/...culum/challenges/_meta/learn-fetch-and-promises-by-building-an-fcc-authors-page/meta.json b/...culum/challenges/_meta/learn-fetch-and-promises-by-building-an-fcc-authors-page/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-fetch-and-promises-by-building-an-fcc-authors-page",
   "helpCategory": "JavaScript",
-  "order": 20,
+  "order": 21,
   "time": "5 hours",
   "template": "",
   "required": [],

diff --git a/curriculum/challenges/_meta/learn-functional-programming-by-building-a-spreadsheet/meta.json b/curriculum/challenges/_meta/learn-functional-programming-by-building-a-spreadsheet/meta.json
@@ -5,7 +5,7 @@
   "hasEditableBoundaries": true,
   "dashedName": "learn-functional-programming-by-building-a-spreadsheet",
   "helpCategory": "JavaScript",
-  "order": 14,
+  "order": 15,
   "time": "2 hours",
   "template": "",
   "required": [],