-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding delete metametrics data to security and privacy tab #24571
Open
NiranjanaBinoy
wants to merge
7
commits into
develop
Choose a base branch
from
delete-metametrics-data-modal
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+505
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
May 22, 2024
JustifyContent, | ||
TextVariant, | ||
} from '../../../helpers/constants/design-system'; | ||
import { createMetaMetricsDataDeletionTask } from '../../../store/actions'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this PR should stay in draft until the controller exists? As-is this is not mergable because this function does not exist.
NiranjanaBinoy
force-pushed
the
delete-metametrics-data-modal
branch
from
May 24, 2024 19:19
cd7937d
to
7660d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependant on #24503
Description
Delete MetaMetrics Data
button.Clear
button in the modal will create a data deletion regulation, update the state, and close the modal, deactivating theDelete MetaMetrics Data
button.Clear
button click opens a new error modal.Scenarios to disable the DeleteMetaMetrics button:
Related issues
Fixes #24406 #24407
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist