fix: filtering product announcements using contentful #24565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
previously approved these changes
May 17, 2024
…aMask/metamask-extension into feat/product-announcements-filtering
Prithpal-Sooriya
previously approved these changes
May 20, 2024
danjm
previously approved these changes
May 22, 2024
matteoscurati
changed the base branch from
develop
to
feat/new-authentication-flow
matteoscurati
changed the base branch from
feat/new-authentication-flow
to
develop
matteoscurati
dismissed stale reviews from Prithpal-Sooriya and danjm
The base branch was changed.
…aMask/metamask-extension into feat/product-announcements-filtering
Builds ready [7768ab7]
Page Load Metrics (668 ± 501 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
May 23, 2024
| @@ -14,7 +14,7 @@ import { TypeActionFields } from '../types/feature-announcement/type-action'; | |||
|
|
|||
| const spaceId = process.env.CONTENTFUL_ACCESS_SPACE_ID || ''; | |||
| const accessToken = process.env.CONTENTFUL_ACCESS_TOKEN || ''; | |||
| export const FEATURE_ANNOUNCEMENT_URL = `https://cdn.contentful.com/spaces/${spaceId}/environments/master/entries?access_token=${accessToken}&content_type=productAnnouncement&include=10`; | |||
| export const FEATURE_ANNOUNCEMENT_URL = `https://cdn.contentful.com/spaces/${spaceId}/environments/master/entries?access_token=${accessToken}&content_type=productAnnouncement&include=10&fields.clients=extension`; | |||
There was a problem hiding this comment.
NOTE - this will change in the future with a dedicated API.
This will be done during our work to migrate the controllers into core.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24565 +/- ##
========================================
Coverage 66.00% 66.00%
========================================
Files 1348 1348
Lines 52503 52503
Branches 13494 13494
========================================
Hits 34651 34651
Misses 17852 17852 ☔ View full report in Codecov by Sentry. |
matteoscurati
changed the title
danjm
approved these changes
May 24, 2024
metamaskbot
added
the
release-11.18.0
Builds ready [807caa5]
Page Load Metrics (915 ± 554 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a filter for receiving product announcements related to the Extension.
Pre-merge author checklist
Pre-merge reviewer checklist