-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metametrics to authentication #24555
feat: add metametrics to authentication #24555
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… NOTIFY-634-send-metametrics-id-on-login
getMetaMetricsId() { | ||
let { metaMetricsId } = this.state; | ||
if (!metaMetricsId) { | ||
metaMetricsId = this.generateMetaMetricsId(); | ||
this.store.updateState({ metaMetricsId }); | ||
} | ||
return metaMetricsId; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change to metametrics.
We are not using the server metametrics ID on the clients.
… NOTIFY-634-send-metametrics-id-on-login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24555 +/- ##
===========================================
+ Coverage 67.37% 67.38% +0.01%
===========================================
Files 1289 1289
Lines 50220 50233 +13
Branches 13005 13006 +1
===========================================
+ Hits 33835 33849 +14
+ Misses 16385 16384 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [995174f]
Page Load Metrics (1569 ± 663 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, LGTM
Description
Allows us to create a lineage (in our system), but will not affect our existing metrics.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist