use expression based properties #3947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanOssendorf
requested changes
May 18, 2024
There was a problem hiding this comment.
I'm in general okay with this change. Last decision lies by @rockfordlhotka
@SimonCropp Could you also please add this change to the editorconfig so it'll b suggested by VS automatically? Thanks
done |
rockfordlhotka
approved these changes
May 20, 2024
|
@StefanOssendorf I'm good with this change - I like the language feature. Once your change request is satisfied it can be merged. |
|
@SimonCropp Please fix the conflicts |
|
Hi @SimonCropp Do you plan to continue working on this PR - to resolve the conflicts - or should I close it without merging? |
|
with that number of conflicts, it is prob easier to close this and resubmit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.