Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python vs matlab #52

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

python vs matlab #52

wants to merge 12 commits into from

Conversation

leandrolecca
Copy link

bhd2022

@leandrolecca leandrolecca marked this pull request as draft November 25, 2022 10:23
TODO: Call MATLAB function from the Python script.
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 90.30% // Head: 90.30% // No change to project coverage 👍

Coverage data is based on head (67749e3) compared to base (90ca567).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files           3        3           
  Lines         299      299           
=======================================
  Hits          270      270           
  Misses         29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

comparison.py Outdated

# Here run matlab script with subprocess.run
print("Running GIFT version of maPCA")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we need to add your edited MATLAB function @leandrolecca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants