Add definition for ASRock X570 Phantom Gaming 4 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the specific sensors and controls for the ASRock Phantom Gaming 4 motherboard.
PhyxionNL
reviewed
Apr 24, 2024
Comment on lines
2610
to
2657
| v.Add(new Voltage("CPUVCORE", 0, 1, 1)); | ||
| v.Add(new Voltage("+5V", 1, 2, 1)); | ||
| v.Add(new Voltage("AVSB", 2, 1, 1)); | ||
| v.Add(new Voltage("3VCC", 3, 1, 1)); | ||
| v.Add(new Voltage("+12V", 4, 56, 10)); | ||
| v.Add(new Voltage("VDDCR_SOC", 5)); | ||
| v.Add(new Voltage("DRAM", 6)); | ||
| v.Add(new Voltage("3VSB", 7, 1, 1)); | ||
| v.Add(new Voltage("VBAT", 8, 1, 1)); | ||
| v.Add(new Voltage("VTT", 9)); | ||
| v.Add(new Voltage("VIN5", 10, true)); // unknown | ||
| v.Add(new Voltage("VPPM", 11, 3, 1)); | ||
| v.Add(new Voltage("PREM_VDDCR_SOC", 12)); | ||
| v.Add(new Voltage("VDDP", 13)); | ||
| v.Add(new Voltage("CPU VDD 1.8V", 14, 1, 1)); | ||
| v.Add(new Voltage("VIN9", 15, true)); // unknown | ||
|
|
||
| t.Add(new Temperature("CPU", 9)); // AKA SMBUSMASTER0 | ||
| t.Add(new Temperature("SB", 10)); // AKA SMBUSMASTER1 | ||
| t.Add(new Temperature("Motherboard", 2)); // AKA SYSTIN | ||
|
|
||
| // no idea what these sources are actually connected to. | ||
| //t.Add(new Temperature("CPUTIN", 1)); | ||
| //t.Add(new Temperature("AUXTIN0", 3)); | ||
| //t.Add(new Temperature("AUXTIN1", 4)); | ||
| //t.Add(new Temperature("AUXTIN2", 5)); | ||
| //t.Add(new Temperature("AUXTIN3", 6)); | ||
| //t.Add(new Temperature("AUXTIN4", 7)); | ||
| //t.Add(new Temperature("TSENSOR", 8)); | ||
| //t.Add(new Temperature("VIRTUAL_TEMP", 24)); | ||
|
|
||
| f.Add(new Fan("CHA_FAN3", 0)); | ||
| c.Add(new Control("CHA_FAN3", 0)); | ||
|
|
||
| f.Add(new Fan("CPU_FAN1", 1)); | ||
| c.Add(new Control("CPU_FAN1", 1)); | ||
|
|
||
| f.Add(new Fan("CPU_FAN2/WP", 2)); | ||
| c.Add(new Control("CPU_FAN2/WP", 2)); | ||
|
|
||
| f.Add(new Fan("CHA_FAN1/WP", 3)); | ||
| c.Add(new Control("CHA_FAN1/WP", 3)); | ||
|
|
||
| f.Add(new Fan("CHA_FAN2/WP", 4)); | ||
| c.Add(new Control("CHA_FAN2/WP", 4)); | ||
|
|
||
| f.Add(new Fan("SB_FAN1", 5)); | ||
| c.Add(new Control("SB_FAN1", 5)); |
There was a problem hiding this comment.
Can you follow naming style as in this file? Such as Vcore, VBat, Chassis Fan #1, etc.
|
Are these names acceptable? I wasn't sure what to do with some of the voltage names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the specific sensors and controls for the ASRock Phantom Gaming 4 motherboard
.