Fix missing view for IT8792E and allow fan control for IT8792E on some Gigabyte AMD boards #1313
+289
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhyxionNL
reviewed
Apr 24, 2024
| if (!WriteToRegister(0xB0) || | ||
| !WriteToValue((byte)((offset >> 8) & 0xFF)) || | ||
| !WriteToValue((byte)(offset & 0xFF))) | ||
| return false; |
There was a problem hiding this comment.
Please follow code style in this file (add braces, new lines, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #251
This PR doesn't directly fix what the issue OP is describing, but fixes some cases related to what is being discussed within the conversation.
Add extra checks for a bugged IT8792E chip. LHM not reporting the chip was because of LHM trying to enter the SuperIO at 0x4E and it causes the chip to report its ID as 0x8883. Not entering actually allows the chip to report correctly as 0x8733.
Implement an ECIO communication to the Gigabyte EC only present on some Gigabyte AMD boards which doesn't have SMFI enabled on the second chip. This allows LHM to disable the Smart Fan control to take control of the chip.