Nct677x esio mutex #1254
Open
Nct677x esio mutex #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the access with multiple devices. Issue: LibreHardwareMonitor#1243 Improper accessing the Nuvoton eSIO causes problems with other monitoring software
sebastian-dev
commented
Jan 30, 2024
| if (access != EC_SPACE_PAGE_SELECT) | ||
| { | ||
| timeout--; | ||
| System.Threading.Thread.Sleep(1); |
There was a problem hiding this comment.
I think no, yield has no defined timing behavior. the the cpu is idle 100*yield can return after 1ms or 100x 20ms when you have 100% cpu load.
Yield has 100% cpu load. Maybe we can capure the time and abort after a timespan or retries.
ensure the wait loop abort after a defined time
…/LibreHardwareMonitor into nct677x_esio-mutex
|
The updated version has a defined timout behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the access with multiple devices.
Issue: #1243
Improper accessing the Nuvoton eSIO causes problems with other monitoring software