feat(plugin): support ordering #82
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopoldthecoder
force-pushed
the
feat/plugin-ordering
branch
from
b6076fc
to
5ac4329
Compare
Leopoldthecoder
force-pushed
the
feat/plugin-ordering
branch
from
5ac4329
to
c3cdb02
Compare
raoxiaoyan
reviewed
Aug 24, 2023
| export const formatVersion = (version: string) => { | ||
| return version.substring(0, (version.indexOf('-') > -1 && version.indexOf('-')) || version.length).split('.').slice(0, 2).join('.') | ||
| } | ||
|
|
||
| export function getMessageFromError ( |
There was a problem hiding this comment.
Does this getMessageFromError rename to getErrorMessage well? what do you think?
There was a problem hiding this comment.
I think both names are acceptable: they are not quite different from each other in terms of meaning.
raoxiaoyan
previously approved these changes
Aug 24, 2023
raoxiaoyan
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Is this file in the directory /spec-ee？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for plugin ordering.
Issue reference
Fix #[issue number]