Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further navbar fixes #110

Merged
merged 7 commits into from
Oct 25, 2016
Merged

Further navbar fixes #110

merged 7 commits into from
Oct 25, 2016

Conversation

stain88
Copy link
Contributor

@stain88 stain88 commented Oct 25, 2016

Hopefully fixes #106
Also changed paths to being root relative, so any further changes to navbar or footer can just be directly copied across pages.

@stain88
Copy link
Contributor Author

stain88 commented Oct 25, 2016

Hmm, looks like I've accidentally merged "fixes" for #109 and #99 in this too

@KirstieJane
Copy link
Owner

Hi @stain88 - thanks for this - I have to say, lining up the indentations etc makes me so so happy!

Unfortunately, making the branches root relative doesn't work here. What should be https://stain88.github.io/STEMMRoleModels/index.html becomes https://stain88.github.io/index.html or https://stain88.github.io/STEMMRoleModels/site/search_database.html becomes https://stain88.github.io/site/search_database.html.

I think it also breaks the connection to the stylesheets...

@KirstieJane
Copy link
Owner

Great - thanks @stain88 - I was going to ask why those changes were there - I hadn't realised they were addressing #99 and #109 😄

@stain88
Copy link
Contributor Author

stain88 commented Oct 25, 2016

Hmm, looks like i need to learn more about gh-pages then...
Wonder if that would still be broken on stemmrolemodels.com. Anyway, I'll revert those paths.

@KirstieJane
Copy link
Owner

Yes - I thought the same thing - but it's so mega convenient to be able to check branches in pull requests that I'd rather the gh-pages branches still worked 😄

Totally followed the logic though!

@stain88
Copy link
Contributor Author

stain88 commented Oct 25, 2016

Ok, that should be all of them

@KirstieJane
Copy link
Owner

Looks great! Thank you @stain88!!

@KirstieJane KirstieJane merged commit b605432 into KirstieJane:gh-pages Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav bar doesn't work on mobile
2 participants