LBFGS inherit from torch.optim.LBFGS #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that the file kan/LBFGS.py appears to be almost identical to the one in PyTorch (https://github.com/pytorch/pytorch/blob/main/torch/optim/lbfgs.py). The only differences seem to be the addition of tolerance_ys and the removal of complex parameter counting.
To maintain consistency and streamline maintenance, it might be preferable to directly inherit from the Torch class.
I've made a commit that does just that, reducing the code to 100 lines. Please review and let me know your thoughts.
Thank you!