add arm64 and armv7l arches to linux CI #2187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofficialgman
added a commit
to Botspot/pi-apps
that referenced
this pull request
Jan 15, 2024
based on upstream PR JannisX11/blockbench#2187 disable updater until upstream PR has merged and downloads are switched to their releases
|
@JannisX11 thoughts? I would have expected some response by now. |
|
@JannisX11 Getting rid of electron-color-picker is an excellent idea. Please let us know what kind of feedback you need. There are a lot of Linux users here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues:
3rd party library is 4+ years unmaintained and does not have ARM64 or ARMhf scrot native binaries on linux https://www.npmjs.com/package/electron-color-picker
electron-color-picker should be moved away from anyway as it is not wayland compatible which is the current default window system on linux desktops in 2024
you will likely want to move to gcolor3 as it seems to work well for me on wayland and x11 due to using the xdg desktop portals for obtaining color information https://www.hjdskes.nl/projects/gcolor3/
I am not actually sure what this library is being used for in blockbench as the "pick screen color" option in the paint section does work on ARM64 xorg linux in testing but not in wayland on any architecture.