Add scrolling support to NumSlider #2070
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add scrolling support to NumSlider.
I am only opening this as a draft for now for some input as this isn't complete.
Someone with a MacOS machine would need to validate the following for Safari:
It is self-resetting to allow a device switch without feeling horrendous, unless you happen to switch to a mouse without leaving the slider.
I shall note that it does make a change to the backing data structure to coerce to an integer via
|0
, which I realise may break the modeller (although surprisingly doesn't?) and plugins expecting to allow non-integer input.This does also introduce a check for bare WebKit specifically for Epiphany, as it is just detected as bare Electron otherwise.