Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage for font-pushster #174018

Merged
merged 1 commit into from
May 17, 2024
Merged

Add homepage for font-pushster #174018

merged 1 commit into from
May 17, 2024

Conversation

milanvarady
Copy link
Contributor

Add the missing homepage to the Pusher font. It has no matching Google Fonts page, so I linked the Lobster font, which is from the same family and technically the same.

@p-linnane
Copy link
Member

/rebase

@bevanjkay
Copy link
Member

This will get overwritten by the automated workflow. I think this is actually a duplicate of font-lobster with some metadata errors.

@milanvarady Do you know anything about the Pushter font?

@milanvarady
Copy link
Contributor Author

@bevanjkay I don't know about the font. Visually it looks exactly the same as font-lobster. The reason I would like this to be fixed is because the empty homepage causes older versions of my Applite app to crash.

It would be nice if this got fixed soon.

@bevanjkay
Copy link
Member

I think we should remove it and skip it in the automated workflow instead. But I'll approve this for now.
Perhaps you should setup the app to show no homepage in these instances?s

@bevanjkay bevanjkay merged commit 35c407c into Homebrew:master May 17, 2024
9 checks passed
@milanvarady
Copy link
Contributor Author

Perhaps you should setup the app to show no homepage in these instances?

I already have but it can't update because it crashes on load.

@krehel
Copy link
Member

krehel commented May 17, 2024

Also agree it should be removed. It seems this is font-lobster with a different name.

@bevanjkay
Copy link
Member

@krehel we will need to skip it in the Google Fonts script. I can have a look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing description Cask is missing a description, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants