feat(cli): added admin usage to table of admins #795
Conversation
|
|
|
Hi, that's great, could you please use sqlalchemy's API rather than executing raw query? |
|
With this database structure it's a little bit complicated, I think it's not worth it. |
done. |
app/db/models.py
Outdated
There was a problem hiding this comment.
why we have duplicate function ? there both do same thing
also we have lifetime_used_traffic function and you can calculate reseted_usage way faster
reseted_usage = lifetime_used_traffic - used_traffic
There was a problem hiding this comment.
that's not same, you have a better idea?
lifetime_used_traffic is not faster :/
lifetime_used_traffic will get all data from database and calculate it in python
by reseted_usage that I add, you will get calculated data from database
There was a problem hiding this comment.
we are doing same thing twice, you can do less job
Another way to avoid more jobs is that we calculate rested usage then for lifetime_used_traffic sum rested usage with used traffic to calculate lifetime_used_traffic
There was a problem hiding this comment.
من در مورد نحوه محاسبه ریست یوزیج ابن کار رو به صورت دستی انجام میدم
مصرف کل به علاوه مانده حجم که مقدار کامل رو درمیارم
برای مثال
اکانت ۵۰ گیگ دوبار کامل مصرف شده ریست شده و حجم کل ۱۳۰ گیگ هستش
۱۳۰ گیگ به اضافه ۲۰ گیگ مانده از ۵۰ گیگ
عکسی که پیوست کردم رو من حجم رو 1100 حساب میکنم
There was a problem hiding this comment.
use power instead of Multiplication
usage // (1024 ** 3)
There was a problem hiding this comment.
actually its better to use from app.utils.system import readable_size function
|
I implemented this feature for my self but one of my friends need this. i told her this is going add in official version, when do you think you can work on it? |
|
guys, i need this |
ما هم همینطور بهش نیاز داریم |
No description provided.