Add / modify user by template #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M03ED
reviewed
Dec 11, 2023
app/utils/share.py
Outdated
There was a problem hiding this comment.
share.py its a file for making configs for users not creating new user
There was a problem hiding this comment.
don't want to make routers too long
and i don't creat a user just create object
app/models/user.py
Outdated
There was a problem hiding this comment.
you can add property here and make user in here at CreateUserFromTemplate class
app/views/user.py
Outdated
|
|
||
|
|
||
| @app.post("/api/user", tags=['User'], response_model=UserResponse) | ||
| def add_user(new_user: UserCreate, | ||
| def add_user(new_user: UserCreate | CreateUserFromTemplate, |
There was a problem hiding this comment.
its better to separate api requests
| @@ -44,6 +44,7 @@ PyMySQL==1.0.3 | |||
| pyOpenSSL==23.2.0 | |||
| pyparsing==3.0.9 | |||
| pypng==0.20220715.0 | |||
| PySocks==1.7.1 | |||
There was a problem hiding this comment.
i can't find where you use this new library
There was a problem hiding this comment.
i try to access telegram use socks and that needed this lib so i added
|
It's good PR, some users ask about this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now we can add or modify user by templates using
POST /api/user/from_templateandPUT /api/user/{username}