Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom S3 URL support #399

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iamdarkle
Copy link

@iamdarkle iamdarkle commented Apr 27, 2024

Fixes #328 #341

Changes proposed in this pull request:
Introduces the ability to configure a custom S3 URL. This feature allows users to specify an alternative S3-compatible storage URL through the admin settings, making the adapter more flexible and capable of integrating with different S3-compatible storage providers like Backblaze B2... etc, probably also useful for MinIO.

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

iamdarkle and others added 7 commits April 27, 2024 19:01
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
@iamdarkle iamdarkle marked this pull request as ready for review April 27, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptor mapping for custom S3 endpoint is incorrect
2 participants