Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FormatTextPreview.php #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edgeinfinity1
Copy link

Fixes #0000

Changes proposed in this pull request:
Fixes the "expand" button's misbehavior while using Text Preview.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca
Copy link
Member

Hi @edgeinfinity1 thanks for your contribution! Please provide steps to reproduce the issue, and maybe add some screenshots/screencasts before and after the change. Thanks!

@edgeinfinity1
Copy link
Author

Hi @edgeinfinity1 thanks for your contribution! Please provide steps to reproduce the issue, and maybe add some screenshots/screencasts before and after the change. Thanks!

I'm sorry for not being able to provide screenshots before the change, because my forum is already in production state.
It's very easy to reproduce the problem:

  1. use "Text Preview" for mime text files.
  2. upload a file within 5 lines, and the expand button shows and does nothing.
  3. upload a file more than 5 lines, and there is no expand button at all.

this problem is obviously because of a misjudgement in rather the file should be expandable, or say just reversed.

@DavideIadeluca DavideIadeluca self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants