Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons]Core Icon Revision #14154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Reqrefusion
Copy link
Contributor

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label May 19, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 20, 2024

IMO the wireframe and hidden line icon is still too similar.
Maybe the hidden line icon should indicate the triangulation?

@Reqrefusion
Copy link
Contributor Author

IMO the wireframe and hidden line icon is still too similar. Maybe the hidden line icon should indicate the triangulation?

It probably mixes it up more. I think changing the perfect made it much, much easier to understand. Also I don't understand this idea. Also, I looked at other programs and it usually happens like this in all of them.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 20, 2024

So you say this makes it easier to understand but you don't understand it? The hidden lines display the triangulated state as the geometry is rendered with Coin3D. IMO not very useful for working with solids but it's the great for meshes.

@Reqrefusion
Copy link
Contributor Author

Reqrefusion commented May 20, 2024

So you say this makes it easier to understand but you don't understand it? The hidden lines display the triangulated state as the geometry is rendered with Coin3D. IMO not very useful for working with solids but it's the great for meshes.

Ok I won't lie. I never looked at this view because I thought it was similar to other CAD programs. Which I don't normally use. I've never used mesh or anything like that. Now I kneel before the greatness of FreeCad. Indeed, this appearance has turned into something useful that can be used.

The downside was that I misunderstood and had to remake the entire group to make their perspectives more understandable. But it was definitely worth it. They became much more understandable.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 22, 2024

I like it now. Thanks.
Please remove src/Gui/Icons/edge-selection.svg this icon from the PR as this will be deleted, otherwise this will get conflicts.
Then please squash your commits.

Copy link
Collaborator

@maxwxyz maxwxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resizing broke several alignments to the pixel grid so the smaller icons appear blurry.
I've attached some screenshots to the before/after. As mentioned, the elements and strokes should be aligned to the pixel grid to prevent aliasing and scale better.
In Inkscape you can view the grid under View -> Page grid.

src/Gui/Icons/accessories-text-editor.svg this icon is a good example how it should be, as everything is aligned.

@kadet1090 @obelisk79 FYI

src/Gui/Icons/button_add_all.svg Show resolved Hide resolved
src/Gui/Icons/accessories-calculator.svg Show resolved Hide resolved
src/Gui/Icons/camera-photo.svg Show resolved Hide resolved
src/Gui/Icons/umf-measurement.svg Show resolved Hide resolved
src/Gui/Icons/debug-marker.svg Show resolved Hide resolved
src/Gui/Icons/application-exit.svg Show resolved Hide resolved
@kadet1090
Copy link
Contributor

Yes, pixel alignment is crucial for the icons to render properly and be sharp so it must be fixed before merging.

Update utilities-terminal.svg

Update button_add_all.svg

pixel alignment

Pixel alignment was performed for the specified icons.
@Reqrefusion
Copy link
Contributor Author

Done, ready to merge.

@chennes
Copy link
Member

chennes commented Jun 7, 2024

@maxwxyz could you please approve (or not, as the case may be!) the change you requested?

@maxwxyz
Copy link
Collaborator

maxwxyz commented Jun 7, 2024

@kadet1090 @obelisk79 could you check as well and comment?

@chennes
Copy link
Member

chennes commented Jun 10, 2024

@obelisk79 if you would like to comment please do so, otherwise we will merge next week.

src/Gui/Icons/DrawStyleAsIs.svg Show resolved Hide resolved
src/Gui/Icons/dagViewPending.svg Show resolved Hide resolved
src/Gui/Icons/dagViewVisible.svg Outdated Show resolved Hide resolved
@Reqrefusion
Copy link
Contributor Author

Reqrefusion commented Jun 11, 2024

dagViewVisible
I don't think this eye looks disproportionate. But I still revert the change.
I made the changes you requested. Do you have another request? @obelisk79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants