PartDesign: hide Suppressed property with FC_USE_TNP_FIX flag #14112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgbsww will this flag be used when implemented so we need to keep track of this change? Or can we enable it by default? |
|
I dunno, appears to be related to the underlying feature. Seems correct; we're going from always hiding this feature to showing it once TNP is enabled, which matches the descriptions. When we are compiling with TNP on, and eventually when we remove all non TNP code, then this property will be visible, which is I think the intention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11212
Suppressed is shown when compiled with FC_USE_TNP_FIX