Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Improve signup styles for when email authentication is disabled #3978

Merged
merged 1 commit into from
May 20, 2024
Merged

style: Improve signup styles for when email authentication is disabled #3978

merged 1 commit into from
May 20, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Centers oauth buttons so that they don't look weird when some are disabled
  • Remove white background when email auth is disabled
image

How did you test this code?

Reviewed the login and signup pages with missing oauths and email signup disabled

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:01pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:01pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:01pm

@kyle-ssg kyle-ssg linked an issue May 17, 2024 that may be closed by this pull request
Styling issue when using SSO only #3951
Closed
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Uffizzi Preview deployment-51901 was deleted.

@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
matthewelwell
matthewelwell approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually by running the FE locally and setting PREVENT_EMAIL_PASSWORD: true

@matthewelwell matthewelwell added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit ce45d67 May 20, 2024
21 checks passed
@matthewelwell matthewelwell deleted the style/signup-without-email-authentication branch May 20, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling issue when using SSO only
2 participants
@kyle-ssg @matthewelwell