refactor: restructured download logic (wip)

[warber]

What this PR does / Why we need it:

Refactored download logic a bit to avoid additional if statement to handle web key user actions.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[github-actions]

Unit Test Results

1 853 tests  ±0   1 853 ✅ ±0   26s ⏱️ ±0s
  131 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit caa02dd. ± Comparison against base commit 80c3b95.

♻️ This comment has been updated with latest results.

[jskelin]

Better that it was.

[UnseenWizzard]

Overall I find it easier to follow to than before, but the mixture of "normal" config APIs types where this downloading will download and unmarshal single objects and things like kua-web where downloading will get and create several entries (and resolves parent API) makes it still a bit hard to follow. Some explanatory comments on the functions would be nice.

[UnseenWizzard]

You didn't introduce this @warber, but: we capture the config to download v in the loop and go routine, rather than passing it as a variable to the go func. This seems not to have caused issues so far - but couldn't it?

[warber]

Isn't that only a problem for go <1.22 ?

[warber]

Overall I find it easier to follow to than before, but the mixture of "normal" config APIs types where this downloading will download and unmarshal single objects and things like kua-web where downloading will get and create several entries (and resolves parent API) makes it still a bit hard to follow. Some explanatory comments on the functions would be nice.

@UnseenWizzard yes i know 😿 if you have any further ideas, feel free to give it a try :)

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud