chore: update jest #27387
chore: update jest #27387
Conversation
VasilyStrelyaev
force-pushed
the
update-jest
branch
2 times, most recently
from
8df4308
to
f423f4d
Compare
VasilyStrelyaev
force-pushed
the
update-jest
branch
from
99f4917
to
11f0ff0
Compare
| @@ -1,5 +1,4 @@ | |||
| module.exports = { | |||
| testEnvironment: 'node', | |||
There was a problem hiding this comment.
In new jest, the default testEnvironment is node (used to be dom). So, now I removed every node value and added dom values where required
| @@ -47,6 +47,7 @@ | |||
| "@angular/platform-server": "16.2.0", | |||
| "@nx/jest": "^16.10.0", | |||
| "@nx/js": "^16.10.0", | |||
| "@types/jest": "^29.5.12", | |||
There was a problem hiding this comment.
Had to manually hoist jest and @types/jest to the top level, where @nx/jest could use them. Previously, they were hoisted by npm, but after update they are no longer hoisted automatically
| "version": "24.1.2" | ||
| "version": "24.1.2", | ||
| "devDependencies": { | ||
| "ts-jest": "^29.1.2" |
There was a problem hiding this comment.
devextreme-monorepo-tools were able to use ts-jest because it was hoisted to the top level by npm, when being declared as a dependency in other workspaces. After update, it is no longer hoisted. Neither are jest and @types/jest.
I manually elevated jest and @types/jest to the top level, because@nx/jest needs them there, and referenced ts-jest here.
| "@types/react": "~18.0.0", | ||
| "@types/react-dom": "~18.0.0", | ||
| "del": "^3.0.0", | ||
| "gulp": "^4.0.2", | ||
| "gulp-header": "^2.0.0", | ||
| "gulp-shell": "^0.8.0", | ||
| "gulp-typescript": "^5.0.1", | ||
| "jest": "^26.6.3", | ||
| "jest-environment-jsdom": "^29.7.0", |
There was a problem hiding this comment.
Since the default testEnvironment is now node, this module should be imported to use dom as the environment.
| @@ -6,7 +6,7 @@ describe('Logger tests', () => { | |||
|
|
|||
| beforeEach(() => { | |||
| jest | |||
| .useFakeTimers('modern') | |||
| .useFakeTimers() | |||
There was a problem hiding this comment.
BC in jest API - now modern timers are the default ones (and the timer type is specified differently)
| @@ -202,18 +201,13 @@ | |||
| "validate-ts": "gulp validate-ts", | |||
| "validate-declarations": "dx-tools validate-declarations --sources ./js --exclude \"js/(renovation|__internal|.eslintrc.js)\" --compiler-options \"{ \\\"typeRoots\\\": [] }\"", | |||
| "testcafe-in-docker": "docker build -f ./testing/testcafe/docker/Dockerfile -t testcafe-testing . && docker run -it testcafe-testing", | |||
| "test-jest": "jest --coverage --runInBand", | |||
| "test-jest": "jest --no-coverage --runInBand", | |||
There was a problem hiding this comment.
Disabled coverage temporarily to delegate its fix to the Grids Squad
| @@ -9,7 +9,8 @@ const DAY_MS = 24 * HOUR_MS; | |||
|
|
|||
| describe('Date utils', () => { | |||
| describe('addOffsets function', () => { | |||
| each`offsets | expectedResult | |||
| each` | |||
| offsets | expectedResult | |||
There was a problem hiding this comment.
Now validation of .each + template literal counts spaces before the table header
| @@ -26,6 +26,9 @@ | |||
| "es2017.object", | |||
| "dom" | |||
| ], | |||
| "types": [ | |||
| "jest" | |||
There was a problem hiding this comment.
#thestrangething, part 1
after updating jest, test files started confusing jest and jasmine types (although they were both already hoisted before, just like they are now)
so now I specified jest explicitly everywhere except angular (that uses jasmine)
| "skipLibCheck": true, | ||
| "lib": [ | ||
| "ES2020", | ||
| "dom" |
There was a problem hiding this comment.
#thestrangething, part 2
But after I rebased it onto upstream, where lib was recently cleared when Ilya bumped the compilation target, TS compiler stopped finding even Array and Object types.
Like my types: ["jest"] overrode even standard types unless they are specified explicitly in lib.
So I had to bring back some lib values to fix that.
| { | ||
| files: ['*'], | ||
| parserOptions: { | ||
| project: true, |
There was a problem hiding this comment.
#thestrangething, part 3
even eslint's TypeScript parser stopped finding basic types, so it inferred any instead all of them. It was fixed by explicitly showing tsconfig files with lib to eslint with the project: true or set to the path.
No description provided.