Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gulp 5 #11968

Merged
merged 5 commits into from
May 21, 2024
Merged

Update to gulp 5 #11968

merged 5 commits into from
May 21, 2024

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 3, 2024

Description

Update to gulp 5.

This is opened as a draft because, while tasks are running, there's still problems. Right now, mainly with the tests.

  • Bump gulp version
  • Remove outdated stream-to-promise in favor of the native finished
  • Remove merge-stream, which does not appear to be maintained. The functionality can be replicated with the gulp API anyway.
  • Rearranged some sequential globs to ensure we're working with the new standard
  • Passed encoding: false whenever sourcing images or other binary files

Issue number and link

Fixes #10919

Testing plan

  1. Ensure make-zip, build-apps, and start task work
  2. Ensure test and test-release pass
  3. Unzip release file
  4. Confirm release sandcastle and viewer app are unchanged

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented May 3, 2024

Thank you for the pull request, @ggetz!

✅ We can confirm we have a CLA on file for you.

@ggetz ggetz marked this pull request as ready for review May 14, 2024 15:10
@ggetz ggetz requested a review from jjspace May 14, 2024 15:10
@ggetz
Copy link
Contributor Author

ggetz commented May 14, 2024

@jjspace Could you please review? The goal would be to get this in sometime this week to ensure it has some time in main before the release.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggetz this mostly looks good, just a few small comments.

I also noticed running npm install complains that install is deprectated. This is from husky install being deprecated. It was replaced just by husky, can you change that in the prepare script?

gulpfile.js Show resolved Hide resolved
gulpfile.js Outdated Show resolved Hide resolved
gulpfile.js Outdated Show resolved Hide resolved
@ggetz
Copy link
Contributor Author

ggetz commented May 20, 2024

Thanks @jjspace! All your feedback should now be addressed.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now thanks @ggetz

@jjspace jjspace merged commit 11dd728 into main May 21, 2024
9 checks passed
@jjspace jjspace deleted the update-gulp branch May 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cesium dependency on es5-ext protestware trojan
2 participants