Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing usecolormodevalue to _dark #409

Closed
wants to merge 2 commits into from

Conversation

gracebir
Copy link

@gracebir gracebir commented Sep 3, 2023

Describe your changes

replacing useColorModeValue with _dark

Screenshots

Screenshot from 2023-09-04 12-08-28

@vercel
Copy link

vercel bot commented Sep 3, 2023

@gracebir is attempting to deploy a commit to the Team Bearstudio Team on Vercel.

A member of the Team first needs to authorize it.

@gracebir gracebir closed this Sep 4, 2023
@gracebir gracebir reopened this Sep 4, 2023
@gracebir gracebir marked this pull request as ready for review September 4, 2023 10:09
@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 10:52am

@ivan-dalmet
Copy link
Member

Hi @gracebir!
Thanks a lot for this PR!
But unfortunately it's seems broken :/
image

You can check here the issue in dark mode
https://start-ui-git-fork-gracebir-revert-usecolormodevalue-bearstudio.vercel.app/storybook/index.html?path=/docs/components-select--docs
image

@ivan-dalmet
Copy link
Member

And by reading the code change, this will not work unfortunately.
The object that you updated needs to output real css not Chakra values ;)

@gracebir
Copy link
Author

gracebir commented Sep 4, 2023

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

@yoannfleurydev
Copy link
Member

yoannfleurydev commented Sep 4, 2023

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

The library we are using for the Select component is react-select and to customize the react-select styles, we can't use Chakra UI "selectors" like _hover or _dark. I think we need to provide real CSS in JS for this component.

Also, we can't use Chakra variables as is (like brand.600) because it has no value in CSS, we need to convert it before (using Chakra's helper) so brand.600 become a CSS value like #ad032c for example.

@gracebir
Copy link
Author

gracebir commented Sep 4, 2023

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

The library we are using for the Select component is react-select and to customize the react-select styles, we can't use Chakra UI "selectors" like _hover or _dark. I think we need to provide real CSS in JS for this component.

Also, we can't use Chakra variables as is (like brand.600) because it has no value in CSS, we need to convert it before (using Chakra's helper) so brand.600 become a CSS value like #ad032c for example.

sure @yoannfleurydev

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants