openssl: stop duplicate ssl key logging for legacy OpenSSL #13683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't call the keylog function if it has already logged the key. For old OpenSSL versions and its forks that do not have support for OpenSSL's keylog callback, libcurl has its own legacy key logging function that logs the TLS 1.2 (and earlier) key (client random + master key) on a single line. Prior to this change, since e7de80e (not in a release), the legacy key logging function could write the same key line more than once (usually twice) due to some incorrect logic. Closes #xxxx
bagder
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For old OpenSSL versions and its forks that do not have support for OpenSSL's keylog callback, libcurl has its own legacy key logging function that logs the TLS 1.2 (and earlier) key (client random + master key) on a single line.
Prior to this change, since e7de80e (not in a release), the legacy key logging function could write the same key line more than once (usually twice) due to some incorrect logic.
Closes #xxxx