Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor prefer-destructuring rule #18472

Merged
merged 4 commits into from
May 28, 2024

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

refactor prefer-destructuring rule docs page to avoid repetition of option's description.

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner May 18, 2024 13:30
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label May 18, 2024
Copy link

netlify bot commented May 18, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e3ffcf0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6654be97c7dbfb0008ae578e
😎 Deploy Preview https://deploy-preview-18472--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last suggestions to clarify wording.

docs/src/rules/prefer-destructuring.md Outdated Show resolved Hide resolved
docs/src/rules/prefer-destructuring.md Outdated Show resolved Hide resolved
docs/src/rules/prefer-destructuring.md Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 80747d2 into eslint:main May 28, 2024
19 of 20 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the docs-refactor branch May 29, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants