Link binary for Karabiner-Elements #174245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanjkay
reviewed
May 19, 2024
| @@ -137,6 +137,8 @@ | |||
|
|
|||
| auto_updates true | |||
|
|
|||
| binary "/Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_cli" | |||
There was a problem hiding this comment.
Does this work on the legacy (pre Big Sur) version? otherwise this should be scoped within the on big_sur :or_newer block.
There was a problem hiding this comment.
The karabiner_cli was introduced in this commit (Mar 5, 2017) and I confirmed that the oldest version in this file (11.6.0, released at Feb 20, 2018) also includes karabiner_cli in the same directory:
https://github.com/pqrs-org/Karabiner-Elements/blob/v11.6.0/make-package.sh#L33-L37
There was a problem hiding this comment.
Thanks for confirming @tshu-w
bevanjkay
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.