fix: fixed the In-Built MIC to work properly after toggling the PSLab MIC

[AsCress]

Fixes #2421 and #2173
This issue was arising primarily due to the following two reasons:-

1. In the ChannelParametersFragment, whenever one checkbox was checked, the other was being unchecked without correcting the state of isAudioInputSelected, causing it to get toggled two times, resulting in it being false, even when one of the audio inputs was selected.
2. In the OscilloscopeActivity, the synchronized method was placed in the wrong scope, causing lock.wait() to get executed even when there was no PSLab Device connected. As there was no input, the thread would keep waiting forever, as lock.notify() would never be called. Hence, it would never detect a change in isAudioInputSelected.

Changes

• app/src/main/java/io/pslab/fragment/ChannelParametersFragment.java - corrected the state of isAudioInputSelected whenever a checkbox is checked, due to another getting unchecked.
• app/src/main/java/io/pslab/activity/OscilloscopeActivity.java - corrected the scope of the synchronized method, so that lock.wait() only gets executed if the PSLab Device is connected.

Screenshots / Recordings

This is a screenshot of the OscilloscopeActivity, after following the required steps to reproduce the issue, as mentioned in #2421.

As one can see, the issue is resolved.

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

[CloudyPadmal]

Looks like this is unused?

[AsCress]

Oh yes! My bad, I had added these for debugging. I'm removing them.

[AsCress]

@CloudyPadmal Done:)

[marcnause]

I have tested the app without the fix and with the fix. I was able to reproduce the problem and I can confirm that I can toggle between both MICs now and the build-in microphone works whenever it is selected in the version which contains the fix.

[marcnause]

@AsCress, just a general remark: I just noticed that you created this pull request on your development branch. I don't know if this was intentional or not. I like to (and sometimes forget to) make an extra branch for every issue I work on (named e.g. issue2421). That way I can switch between working on different issues. Even more convenient: Waiting for the merge of a pull request does not block me from working on other issues.

[AsCress]

@AsCress, just a general remark: I just noticed that you created this pull request on your development branch. I don't know if this was intentional or not. I like to (and sometimes forget to) make an extra branch for every issue I work on (named e.g. issue2421). That way I can switch between working on different issues. Even more convenient: Waiting for the merge of a pull request does not block me from working on other issues.

@marcnause Thank you very much for testing the fix and your comments!! I'll surely make extra branches for different issues from now on.