Add model and form to create and edit exhibitors #9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongquan Could you please review this PR |
|
Please add only one new migration file per app. Your new "events" app is adding 3 new migrations. It is redundant. Also please format your new code with Ruff. |
hongquan
requested changes
Mar 26, 2024
event_topics/models.py
Outdated
| event_topic_id = models.ForeignKey(EventTopic, on_delete=models.CASCADE, null=True) | ||
|
|
||
| def __str__(self): | ||
| return self.name |
There was a problem hiding this comment.
You name field is defined as null=True, so self.name can be None. It is illegal for __str__ (must always be string).
There was a problem hiding this comment.
Sorry for the delay. I have added the suggested changes. Pls review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9111
Short description of what this resolves:
Added model and form to create and edit exhibitors
Changes proposed in this pull request:
Exhibitorsinsideeventsapp.forms.pyfilePS - This PR builds on top of work done in PR #9125. Please merge it before merging this PR.
Checklist
developmentbranch.