updated the server/requirements.txt to latest version #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks Ok. As far as I remember, there is no breakage when jumping from Django 4.2 to 5.0. |
Really? I'm surprised they bump the major if there's no breaking changes then, but let me check... |
|
Doesn't seem compatible, see "release cadence": https://docs.djangoproject.com/en/dev/internals/release-process/ |
|
Have these changes been tested somewhere @AviGawande? |
|
Not yet , because there was a django-package depreciation in it. |
|
Let's not merge untested dependencies upgrades, that's dangerous, specially with a major update on Django itself. Let us know when you test it out. |
marcoag
requested changes
May 29, 2024
|
Ok I will test on my branch and let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now there are lot of deprecated version of the server/requirements.txt of eventyay-video and due to this deprecations the cause an error while running the development environment locally. Prior to this PR the dependabot had tried to automate the updations but the changes are not really reflected in the codebase.